Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1360943002: Devtools: Extensible mime typing, mime typing by file name (Closed)

Created:
5 years, 3 months ago by wes
Modified:
5 years, 2 months ago
Reviewers:
paulirish, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Extensible mime typing, mime typing by file name This work was split from https://codereview.chromium.org/1264133002/ BUG=484261

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -8 lines) Patch
M Source/devtools/front_end/common/ResourceType.js View 1 chunk +35 lines, -1 line 2 comments Download
M Source/devtools/front_end/common/TextUtils.js View 1 chunk +28 lines, -0 lines 2 comments Download
M Source/devtools/front_end/sources/SourcesView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/workspace/UISourceCode.js View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
wes
5 years, 3 months ago (2015-09-23 00:24:04 UTC) #2
wes
5 years, 2 months ago (2015-10-13 21:04:58 UTC) #3
pfeldman
https://codereview.chromium.org/1360943002/diff/1/Source/devtools/front_end/common/ResourceType.js File Source/devtools/front_end/common/ResourceType.js (right): https://codereview.chromium.org/1360943002/diff/1/Source/devtools/front_end/common/ResourceType.js#newcode163 Source/devtools/front_end/common/ResourceType.js:163: WebInspector.ResourceType.newMimeType = function(extensionOrName, mime, byName) Do we need this ...
5 years, 2 months ago (2015-10-22 17:38:22 UTC) #4
wes
5 years, 2 months ago (2015-10-23 19:00:41 UTC) #5 
https://codereview.chromium.org/1360943002/diff/1/Source/devtools/front_end/c...
File Source/devtools/front_end/common/ResourceType.js (right):

https://codereview.chromium.org/1360943002/diff/1/Source/devtools/front_end/c...
Source/devtools/front_end/common/ResourceType.js:163:
WebInspector.ResourceType.newMimeType = function(extensionOrName, mime, byName)
On 2015/10/22 17:38:22, pfeldman wrote:
> Do we need this method? Seems like mimeFromURL is solving it.

mimeFromURL canonically maps a URL to a corresponding mimetype, while
newMimeType is an endpoint to add new mime types as runtime (as in through
extensions). I mean, we could always edit the
WebInspector.ResourceType.mimeTypeByExtension and
WebInspector.ResourceType.mimeTypeByName objects directly, but having a
canonical function for doing so seemed sensible.

https://codereview.chromium.org/1360943002/diff/1/Source/devtools/front_end/c...
File Source/devtools/front_end/common/TextUtils.js (right):

https://codereview.chromium.org/1360943002/diff/1/Source/devtools/front_end/c...
Source/devtools/front_end/common/TextUtils.js:153: _lastSectionBeforeQuery:
function(text, delimiter)
On 2015/10/22 17:38:22, pfeldman wrote:
> Annotate please.

Is it considered good practice to annotate all private methods? I've notice the
CC isn't configured to require it.

Powered by Google App Engine
This is Rietveld 408576698