Don't send mouse events if the plugin doesn't have focus.

Don't send mouse events if the plugin doesn't have focus.

This works around http://crbug.com/246335 and reinstates the fix for http://crbug.com/236549.

BUG=236549
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268435

[Jamie, 2014-02-07 22:34:39]

ptal

https://codereview.chromium.org/136093013/diff/60001/remoting/client/plugin/p...
File remoting/client/plugin/pepper_input_handler.cc (right):

https://codereview.chromium.org/136093013/diff/60001/remoting/client/plugin/p...
remoting/client/plugin/pepper_input_handler.cc:79: return false;
I'm in two minds about this one. Some platforms (such as Mac) do not typically
pass the first click on an unfocused window to that window for processing; on
those platforms, a second click is needed to interact with the window after it
has been focused. On other platforms (such as Windows), the click that activates
a window is also processed by that window; on these platforms, a single click on
a UI element of an unfocused window will activate it.

By suppressing clicks when unfocused, we get the first behaviour. I've chosen it
because otherwise a right-click on an inactive Chromoting window will be passed
to the host (dismissing any screensaver, for example) but, at least on Mac, will
not active the Chromoting window itself. This is far less confusing than a
window that may have been inactive for some time awakening on mouse move, but is
still potentially confusing.

[weitao, 2014-02-07 23:54:23]

Could you please fix the key events too?

LGTM

https://codereview.chromium.org/136093013/diff/60001/remoting/client/plugin/p...
File remoting/client/plugin/pepper_input_handler.cc (right):

https://codereview.chromium.org/136093013/diff/60001/remoting/client/plugin/p...
remoting/client/plugin/pepper_input_handler.cc:55: case
PP_INPUTEVENT_TYPE_KEYDOWN:
While at it, could you please also ignore key events when the webapp doesn't
have focus? That will fix crbug.com/236549.

https://codereview.chromium.org/136093013/diff/60001/remoting/client/plugin/p...
remoting/client/plugin/pepper_input_handler.cc:79: return false;
I agree the first behavior is better.

On 2014/02/07 22:34:39, Jamie wrote:
> I'm in two minds about this one. Some platforms (such as Mac) do not typically
> pass the first click on an unfocused window to that window for processing; on
> those platforms, a second click is needed to interact with the window after it
> has been focused. On other platforms (such as Windows), the click that
activates
> a window is also processed by that window; on these platforms, a single click
on
> a UI element of an unfocused window will activate it.
> 
> By suppressing clicks when unfocused, we get the first behaviour. I've chosen
it
> because otherwise a right-click on an inactive Chromoting window will be
passed
> to the host (dismissing any screensaver, for example) but, at least on Mac,
will
> not active the Chromoting window itself. This is far less confusing than a
> window that may have been inactive for some time awakening on mouse move, but
is
> still potentially confusing.

https://codereview.chromium.org/136093013/diff/60001/remoting/webapp/client_s...
File remoting/webapp/client_session.js (right):

https://codereview.chromium.org/136093013/diff/60001/remoting/webapp/client_s...
remoting/webapp/client_session.js:355: 0);
Nice trick. :)

[Jamie, 2014-02-08 00:12:53]

fyi

https://codereview.chromium.org/136093013/diff/60001/remoting/client/plugin/p...
File remoting/client/plugin/pepper_input_handler.cc (right):

https://codereview.chromium.org/136093013/diff/60001/remoting/client/plugin/p...
remoting/client/plugin/pepper_input_handler.cc:55: case
PP_INPUTEVENT_TYPE_KEYDOWN:
On 2014/02/07 23:54:23, weitaosu wrote:
> While at it, could you please also ignore key events when the webapp doesn't
> have focus? That will fix crbug.com/236549.

We don't get key events when we don't have focus.

[Jamie, 2014-02-08 00:12:57]

The CQ bit was checked by jamiewalch@chromium.org

[commit-bot: I haz the power, 2014-02-08 00:13:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/136093013/60001

[commit-bot: I haz the power, 2014-02-08 01:55:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-08 01:55:26]

Retried try job too often on win_rel for step(s) telemetry_perf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Jamie, 2014-05-06 01:29:53]

The CQ bit was checked by jamiewalch@chromium.org

[commit-bot: I haz the power, 2014-05-06 01:30:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/136093013/60001

[commit-bot: I haz the power, 2014-05-06 05:44:10]

Change committed as 268435