Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 136093011: [App Shell] Port app_shell to windows aura. (Closed)

Created:
6 years, 10 months ago by Haojian Wu
Modified:
6 years, 10 months ago
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org, Yoyo Zhou
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[App Shell] Port app_shell to windows aura. Allow windows developsers to run app_shell. BUG=None TEST=Build app_shell on windows with use_aura=1, it launches normally. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248870

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M apps/apps.gypi View 1 2 chunks +13 lines, -1 line 0 comments Download
M apps/shell/app/DEPS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M apps/shell/app/shell_main.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Haojian Wu
A new CL to replace CL: https://codereview.chromium.org/149463002/
6 years, 10 months ago (2014-02-01 12:01:57 UTC) #1
James Cook
LGTM. You'll need an owner from src/sandbox to approve the additional to DEPS (which seems ...
6 years, 10 months ago (2014-02-02 00:13:58 UTC) #2
Haojian Wu
On 2014/02/02 00:13:58, James Cook wrote: > LGTM. You'll need an owner from src/sandbox to ...
6 years, 10 months ago (2014-02-02 00:36:37 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
6 years, 10 months ago (2014-02-03 22:51:08 UTC) #4
James Cook
On 2014/02/03 22:51:08, cpu wrote: > lgtm FYI - you'll need to rebase, I just ...
6 years, 10 months ago (2014-02-03 23:14:50 UTC) #5
Haojian Wu
The CQ bit was checked by hokein.wu@gmail.com
6 years, 10 months ago (2014-02-04 03:50:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/136093011/80001
6 years, 10 months ago (2014-02-04 03:51:22 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 04:11:03 UTC) #8
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=145881
6 years, 10 months ago (2014-02-04 04:11:03 UTC) #9
Haojian Wu
The CQ bit was checked by hokein.wu@gmail.com
6 years, 10 months ago (2014-02-04 04:28:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/136093011/80001
6 years, 10 months ago (2014-02-04 04:28:54 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 05:49:25 UTC) #12
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120476
6 years, 10 months ago (2014-02-04 05:49:25 UTC) #13
Haojian Wu
The CQ bit was checked by hokein.wu@gmail.com
6 years, 10 months ago (2014-02-05 02:49:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/136093011/80001
6 years, 10 months ago (2014-02-05 03:41:59 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 06:14:16 UTC) #16
Message was sent while issue was closed.
Change committed as 248870

Powered by Google App Engine
This is Rietveld 408576698