Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: src/a64/lithium-a64.cc

Issue 136093005: A64: Move integer exponent into correct register before calling MathPowStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Use register constraints. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/a64/lithium-codegen-a64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1891 matching lines...) Expand 10 before | Expand all | Expand 10 after
1902 } 1902 }
1903 1903
1904 1904
1905 LInstruction* LChunkBuilder::DoPower(HPower* instr) { 1905 LInstruction* LChunkBuilder::DoPower(HPower* instr) {
1906 ASSERT(instr->representation().IsDouble()); 1906 ASSERT(instr->representation().IsDouble());
1907 // We call a C function for double power. It can't trigger a GC. 1907 // We call a C function for double power. It can't trigger a GC.
1908 // We need to use fixed result register for the call. 1908 // We need to use fixed result register for the call.
1909 Representation exponent_type = instr->right()->representation(); 1909 Representation exponent_type = instr->right()->representation();
1910 ASSERT(instr->left()->representation().IsDouble()); 1910 ASSERT(instr->left()->representation().IsDouble());
1911 LOperand* left = UseFixedDouble(instr->left(), d0); 1911 LOperand* left = UseFixedDouble(instr->left(), d0);
1912 LOperand* right = exponent_type.IsDouble() ? 1912 LOperand* right = exponent_type.IsInteger32()
1913 UseFixedDouble(instr->right(), d1) : 1913 ? UseFixed(instr->right(), x12)
1914 UseFixed(instr->right(), x11); 1914 : exponent_type.IsDouble()
1915 ? UseFixedDouble(instr->right(), d1)
1916 : UseFixed(instr->right(), x11);
1915 LPower* result = new(zone()) LPower(left, right); 1917 LPower* result = new(zone()) LPower(left, right);
1916 return MarkAsCall(DefineFixedDouble(result, d0), 1918 return MarkAsCall(DefineFixedDouble(result, d0),
1917 instr, 1919 instr,
1918 CAN_DEOPTIMIZE_EAGERLY); 1920 CAN_DEOPTIMIZE_EAGERLY);
1919 } 1921 }
1920 1922
1921 1923
1922 LInstruction* LChunkBuilder::DoPushArgument(HPushArgument* instr) { 1924 LInstruction* LChunkBuilder::DoPushArgument(HPushArgument* instr) {
1923 ++argument_count_; 1925 ++argument_count_;
1924 LOperand* argument = UseRegister(instr->argument()); 1926 LOperand* argument = UseRegister(instr->argument());
(...skipping 579 matching lines...) Expand 10 before | Expand all | Expand 10 after
2504 LInstruction* LChunkBuilder::DoWrapReceiver(HWrapReceiver* instr) { 2506 LInstruction* LChunkBuilder::DoWrapReceiver(HWrapReceiver* instr) {
2505 LOperand* receiver = UseRegister(instr->receiver()); 2507 LOperand* receiver = UseRegister(instr->receiver());
2506 LOperand* function = UseRegisterAtStart(instr->function()); 2508 LOperand* function = UseRegisterAtStart(instr->function());
2507 LOperand* temp = TempRegister(); 2509 LOperand* temp = TempRegister();
2508 LWrapReceiver* result = new(zone()) LWrapReceiver(receiver, function, temp); 2510 LWrapReceiver* result = new(zone()) LWrapReceiver(receiver, function, temp);
2509 return AssignEnvironment(DefineAsRegister(result)); 2511 return AssignEnvironment(DefineAsRegister(result));
2510 } 2512 }
2511 2513
2512 2514
2513 } } // namespace v8::internal 2515 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/a64/lithium-codegen-a64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698