Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 1360923002: Rebaseline over 300 tests for Mac 10.10 text changes. (Closed)

Created:
5 years, 3 months ago by jbroman
Modified:
5 years, 3 months ago
Reviewers:
bungeman-chromium
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rebaseline over 300 tests for Mac 10.10 text changes. fast/dom/shadowdom-for-button.html needs further triage by bungeman@. fast/forms/menulist-narrow-width.html was also affected, but covered by another line in TestExpectations. BUG=524646 TBR=bungeman@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202651

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +321 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360923002/1
5 years, 3 months ago (2015-09-22 23:33:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202651
5 years, 3 months ago (2015-09-22 23:43:36 UTC) #3
bungeman-skia
On 2015/09/22 23:43:36, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
5 years, 3 months ago (2015-09-23 19:13:00 UTC) #4
jbroman
On 2015/09/23 at 19:13:00, bungeman wrote: > On 2015/09/22 23:43:36, commit-bot: I haz the power ...
5 years, 3 months ago (2015-09-23 19:17:49 UTC) #5
jbroman
5 years, 3 months ago (2015-09-23 19:18:07 UTC) #6
Message was sent while issue was closed.
On 2015/09/23 at 19:17:49, jbroman wrote:
> On 2015/09/23 at 19:13:00, bungeman wrote:
> > On 2015/09/22 23:43:36, commit-bot: I haz the power wrote:
> > > Committed patchset #1 (id:1) as
> > > https://src.chromium.org/viewvc/blink?view=rev&revision=202651
> > 
> > Investigating now suppressed fast/dom/shadow/shadowdom-for-button.html , but
on the bots it appears that fast/forms/menulist-narrow-width.html is failing on
the main builders now? It appears to be marked as ImageOnlyFailure, and since
the font changed the metrics did as well, meaning that the text expectations
have now changed.
> 
> Right, that one got lost because it conflicted with another expectation. I
sent another CL to the CQ that should handle that, once merge-related things
unbreak enough.

erm, "that one" being menulist-narrow-width.hmtl

Powered by Google App Engine
This is Rietveld 408576698