android_webview/native/aw_web_contents_delegate.cc - Issue 13609002: fix a problem that android cannot download files with basic authentication

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_web_contents_delegate.cc

Issue 13609002: fix a problem that android cannot download files with basic authentication (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/native/aw_web_contents_delegate.h ('k') | chrome/browser/android/chrome_web_contents_delegate_android.h » ('j') | content/public/browser/web_contents_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_web_contents_delegate.cc

diff --git a/android_webview/native/aw_web_contents_delegate.cc b/android_webview/native/aw_web_contents_delegate.cc

index ef9355034abcd2f74fbec4d6421cc440a28e0209..eec472599db7848db14d6a80219d5867f6e22f1e 100644

--- a/android_webview/native/aw_web_contents_delegate.cc

+++ b/android_webview/native/aw_web_contents_delegate.cc

@@ -54,6 +54,7 @@ void AwWebContentsDelegate::FindReply(WebContents* web_contents,

bool AwWebContentsDelegate::CanDownload(content::RenderViewHost* source,

int request_id,

+ bool has_auth,

const std::string& request_method) {

// Android webview intercepts download in its resource dispatcher host

// delegate, so should not reach here.