fix a problem that android cannot download files with basic authentication

net/http/http_network_transaction.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_network_transaction.h"
 
 #include <set>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 748 matching lines @@
   }
 
   // Honor load flags that impact proxy caches.
   if (request_->load_flags & LOAD_BYPASS_CACHE) {
     request_headers_.SetHeader(HttpRequestHeaders::kPragma, "no-cache");
     request_headers_.SetHeader(HttpRequestHeaders::kCacheControl, "no-cache");
   } else if (request_->load_flags & LOAD_VALIDATE_CACHE) {
     request_headers_.SetHeader(HttpRequestHeaders::kCacheControl, "max-age=0");
   }
 
-  if (ShouldApplyProxyAuth() && HaveAuth(HttpAuth::AUTH_PROXY))
+  bool has_auth = false;
+  if (ShouldApplyProxyAuth() && HaveAuth(HttpAuth::AUTH_PROXY)) {
     auth_controllers_[HttpAuth::AUTH_PROXY]->AddAuthorizationHeader(
         &request_headers_);
-  if (ShouldApplyServerAuth() && HaveAuth(HttpAuth::AUTH_SERVER))
+    has_auth = true;

[asanka, 2013/04/09 21:55:13]

These are redundant with the check below. If the AddAuthorizationHeader() calls
succeed, then the headers would be present when you check them again below. If
they fail, then the request is technically not using authentication.

[qinmin, 2013/04/09 22:10:06]

ah... ok, done

On 2013/04/09 21:55:13, asanka wrote:

+  }
+  if (ShouldApplyServerAuth() && HaveAuth(HttpAuth::AUTH_SERVER)) {
     auth_controllers_[HttpAuth::AUTH_SERVER]->AddAuthorizationHeader(
         &request_headers_);
+    has_auth = true;
+  }
 
   request_headers_.MergeFrom(request_->extra_headers);
+  has_auth = has_auth && (
+      request_headers_.HasHeader(HttpRequestHeaders::kAuthorization) ||
+      request_headers_.HasHeader(HttpRequestHeaders::kProxyAuthorization));
+  response_.did_use_http_auth = has_auth;
 }
 
 int HttpNetworkTransaction::DoInitRequestBody() {
   next_state_ = STATE_INIT_REQUEST_BODY_COMPLETE;
   int rv = OK;
   if (request_->upload_data_stream)
     rv = request_->upload_data_stream->Init(io_callback_);
   return rv;
 }
 
@@ skipping 674 matching lines @@
       description = base::StringPrintf("Unknown state 0x%08X (%u)", state,
                                        state);
       break;
   }
   return description;
 }
 
 #undef STATE_CASE
 
 }  // namespace net