fix a problem that android cannot download files with basic authentication

net/http/http_network_transaction.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_network_transaction.h"
 
 #include <set>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 748 matching lines @@
   }
 
   // Honor load flags that impact proxy caches.
   if (request_->load_flags & LOAD_BYPASS_CACHE) {
     request_headers_.SetHeader(HttpRequestHeaders::kPragma, "no-cache");
     request_headers_.SetHeader(HttpRequestHeaders::kCacheControl, "no-cache");
   } else if (request_->load_flags & LOAD_VALIDATE_CACHE) {
     request_headers_.SetHeader(HttpRequestHeaders::kCacheControl, "max-age=0");
   }
 
-  if (ShouldApplyProxyAuth() && HaveAuth(HttpAuth::AUTH_PROXY))
+  response_.request_has_auth = false;
+  if (ShouldApplyProxyAuth() && HaveAuth(HttpAuth::AUTH_PROXY)) {
     auth_controllers_[HttpAuth::AUTH_PROXY]->AddAuthorizationHeader(
         &request_headers_);
-  if (ShouldApplyServerAuth() && HaveAuth(HttpAuth::AUTH_SERVER))
+    response_.request_has_auth = true;
+  }
+  if (ShouldApplyServerAuth() && HaveAuth(HttpAuth::AUTH_SERVER)) {
     auth_controllers_[HttpAuth::AUTH_SERVER]->AddAuthorizationHeader(
         &request_headers_);
+    response_.request_has_auth = true;
+  }
 
   request_headers_.MergeFrom(request_->extra_headers);

[asanka, 2013/04/09 17:38:51]

I'm sorry I didn't see this earlier. Authorization headers could also come from
request_->extra_headers. In this case, the flag in response_ may be incorrect.

You'll need to check for the kAuthorization and kProxyAuthorization headers
after all the headers are done to check if the request is going to use HTTP
auth.

This is unlikely to be a problem on Android, but since this flag is going to
exist on all platforms, we should make sure it's correct.

[qinmin, 2013/04/09 20:19:06]

Done.

 }
 
 int HttpNetworkTransaction::DoInitRequestBody() {
   next_state_ = STATE_INIT_REQUEST_BODY_COMPLETE;
   int rv = OK;
   if (request_->upload_data_stream)
     rv = request_->upload_data_stream->Init(io_callback_);
   return rv;
 }
 
@@ skipping 674 matching lines @@
       description = base::StringPrintf("Unknown state 0x%08X (%u)", state,
                                        state);
       break;
   }
   return description;
 }
 
 #undef STATE_CASE
 
 }  // namespace net