Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1360873003: Fix WebUSB notification on Chrome OS with no windows open. (Closed)

Created:
5 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 3 months ago
Reviewers:
juncai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WebUSB notification on Chrome OS with no windows open. This patch fixes WebUSB notifications so that Chrome does not crash when opening the landing page URL on Chrome OS when there are no windows open. This is done with a ScopedTabbedBrowserDisplayer which will create a new browser window if one is not visible. The notification strings are also updated to match the most recent mocks. BUG=492204 Committed: https://crrev.com/48291d82d4080d05975da8949b5cd7e92d7a0a1e Cr-Commit-Position: refs/heads/master@{#350360}

Patch Set 1 #

Patch Set 2 : Update expected strings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -35 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_webusb_browser_client.cc View 3 chunks +26 lines, -22 lines 0 comments Download
M chrome/browser/chrome_webusb_browser_client_unittest.cc View 1 2 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 3 months ago (2015-09-22 21:37:56 UTC) #2
juncai
lgtm
5 years, 3 months ago (2015-09-22 22:00:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360873003/1
5 years, 3 months ago (2015-09-22 22:17:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/116554)
5 years, 3 months ago (2015-09-22 22:39:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360873003/20001
5 years, 3 months ago (2015-09-22 23:55:41 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/72404)
5 years, 3 months ago (2015-09-23 05:22:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360873003/20001
5 years, 3 months ago (2015-09-23 18:30:46 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-23 20:28:30 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 20:30:19 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/48291d82d4080d05975da8949b5cd7e92d7a0a1e
Cr-Commit-Position: refs/heads/master@{#350360}

Powered by Google App Engine
This is Rietveld 408576698