Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: snapshot/win/process_snapshot_win.h

Issue 1360863006: win: Add more memory regions to gathering of PEB (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@save-peb
Patch Set: determine size of envblock Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | snapshot/win/process_snapshot_win.cc » ('j') | snapshot/win/process_snapshot_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/win/process_snapshot_win.h
diff --git a/snapshot/win/process_snapshot_win.h b/snapshot/win/process_snapshot_win.h
index bba9828f3a167398cdf6d8a9dd03ebdbf743cd24..83ea98ef6a05c2454bfe26b18d7d2118b22bcc93 100644
--- a/snapshot/win/process_snapshot_win.h
+++ b/snapshot/win/process_snapshot_win.h
@@ -40,6 +40,7 @@
#include "util/misc/initialization_state_dcheck.h"
#include "util/misc/uuid.h"
#include "util/win/address_types.h"
+#include "util/win/process_structs.h"
#include "util/stdlib/pointer_container.h"
namespace crashpad {
@@ -134,8 +135,24 @@ class ProcessSnapshotWin final : public ProcessSnapshot {
// Initializes modules_ on behalf of Initialize().
void InitializeModules();
+ // Initializes peb_memory_ on behalf of Initialize().
+ template <class Traits>
+ void InitializePebData();
+
+ void AddMemorySnapshot(WinVMAddress address,
+ WinVMSize size,
+ PointerVector<internal::MemorySnapshotWin>* into);
+
+ template <class Traits>
+ void AddMemorySnapshotForUNICODE_STRING(
+ const process_types::UNICODE_STRING<Traits>& us,
+ PointerVector<internal::MemorySnapshotWin>* into);
+
+ WinVMSize DetermineSizeOfEnvironmentBlock(
+ WinVMAddress start_of_environment_block);
+
internal::SystemSnapshotWin system_;
- internal::MemorySnapshotWin peb_;
+ PointerVector<internal::MemorySnapshotWin> peb_memory_;
PointerVector<internal::ThreadSnapshotWin> threads_;
PointerVector<internal::ModuleSnapshotWin> modules_;
scoped_ptr<internal::ExceptionSnapshotWin> exception_;
« no previous file with comments | « no previous file | snapshot/win/process_snapshot_win.cc » ('j') | snapshot/win/process_snapshot_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698