Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 136083002: Fix 2010e compile by adding intsafe_workaround to SDCH. (Closed)

Created:
6 years, 11 months ago by dcheng
Modified:
6 years, 11 months ago
Reviewers:
wtc, scottmg
CC:
chromium-reviews, ncarter (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix 2010e compile by adding intsafe_workaround to SDCH. Patch from joaodasilva. BUG=308740 R=scottmg@chromium.org TBR=wtc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244469

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M sdch/sdch.gyp View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
dcheng
6 years, 11 months ago (2014-01-13 01:46:07 UTC) #1
scottmg
lgtm
6 years, 11 months ago (2014-01-13 01:55:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/136083002/1
6 years, 11 months ago (2014-01-13 04:08:05 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 11 months ago (2014-01-13 06:59:21 UTC) #4
dcheng
Committed patchset #1 manually as r244469 (presubmit successful).
6 years, 11 months ago (2014-01-13 07:00:07 UTC) #5
wtc
6 years, 11 months ago (2014-01-13 20:54:03 UTC) #6
Message was sent while issue was closed. 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698