Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Side by Side Diff: src/runtime/runtime-internal.cc

Issue 1360793002: [builtins] Refactor Invoke to deal with any kind of callable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/bootstrapper.h" 8 #include "src/bootstrapper.h"
9 #include "src/conversions.h" 9 #include "src/conversions.h"
10 #include "src/debug/debug.h" 10 #include "src/debug/debug.h"
11 #include "src/frames-inl.h" 11 #include "src/frames-inl.h"
12 #include "src/isolate-inl.h" 12 #include "src/isolate-inl.h"
13 #include "src/messages.h" 13 #include "src/messages.h"
14 #include "src/parser.h"
15 #include "src/prettyprinter.h"
14 16
15 namespace v8 { 17 namespace v8 {
16 namespace internal { 18 namespace internal {
17 19
18 RUNTIME_FUNCTION(Runtime_CheckIsBootstrapping) { 20 RUNTIME_FUNCTION(Runtime_CheckIsBootstrapping) {
19 SealHandleScope shs(isolate); 21 SealHandleScope shs(isolate);
20 DCHECK(args.length() == 0); 22 DCHECK(args.length() == 0);
21 RUNTIME_ASSERT(isolate->bootstrapper()->IsActive()); 23 RUNTIME_ASSERT(isolate->bootstrapper()->IsActive());
22 return isolate->heap()->undefined_value(); 24 return isolate->heap()->undefined_value();
23 } 25 }
(...skipping 378 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 RUNTIME_ASSERT(it.frame()->type() == StackFrame::JAVA_SCRIPT); 404 RUNTIME_ASSERT(it.frame()->type() == StackFrame::JAVA_SCRIPT);
403 return JavaScriptFrame::cast(it.frame())->function(); 405 return JavaScriptFrame::cast(it.frame())->function();
404 } 406 }
405 407
406 408
407 RUNTIME_FUNCTION(Runtime_GetCodeStubExportsObject) { 409 RUNTIME_FUNCTION(Runtime_GetCodeStubExportsObject) {
408 HandleScope shs(isolate); 410 HandleScope shs(isolate);
409 return isolate->heap()->code_stub_exports_object(); 411 return isolate->heap()->code_stub_exports_object();
410 } 412 }
411 413
414
415 namespace {
416
417 Handle<String> RenderCallSite(Isolate* isolate, Handle<Object> object) {
418 MessageLocation location;
419 if (isolate->ComputeLocation(&location)) {
420 Zone zone;
421 base::SmartPointer<ParseInfo> info(
422 location.function()->shared()->is_function()
423 ? new ParseInfo(&zone, location.function())
424 : new ParseInfo(&zone, location.script()));
425 if (Parser::ParseStatic(info.get())) {
426 CallPrinter printer(isolate, &zone);
427 const char* string = printer.Print(info->literal(), location.start_pos());
428 return isolate->factory()->NewStringFromAsciiChecked(string);
429 } else {
430 isolate->clear_pending_exception();
431 }
432 }
433 return Object::TypeOf(isolate, object);
434 }
435
436 } // namespace
437
438
439 RUNTIME_FUNCTION(Runtime_ThrowCalledNonCallable) {
440 HandleScope scope(isolate);
441 DCHECK_EQ(1, args.length());
442 CONVERT_ARG_HANDLE_CHECKED(Object, object, 0);
443 Handle<String> callsite = RenderCallSite(isolate, object);
444 THROW_NEW_ERROR_RETURN_FAILURE(
445 isolate, NewTypeError(MessageTemplate::kCalledNonCallable, callsite));
446 }
447
412 } // namespace internal 448 } // namespace internal
413 } // namespace v8 449 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698