Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Issue 1360793002: [builtins] Refactor Invoke to deal with any kind of callable. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtin] Refactor Invoke to deal with any kind of callable. Now both Execution::Call and Execution::New can deal with any kind of target and will raise a proper exception if the target is not callable (which is not yet spec compliant for New, as we would have to check IsConstructor instead, which we don't have yet). Now we no longer need to do any of these weird call/construct delegate gymnastics in C++, and we finally have a single true bottleneck for Call/Construct abstract operations in the code base, with only a few special handlings left in the compilers to optimize the JSFunction case. R=jarin@chromium.org BUG=v8:4430, v8:4413 LOG=n Committed: https://crrev.com/634d1d86d8e98584097c6cb548a68ecf705c44f7 Cr-Commit-Position: refs/heads/master@{#30874}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -451 lines) Patch
M src/api.cc View 2 chunks +2 lines, -23 lines 0 comments Download
M src/arm/builtins-arm.cc View 3 chunks +40 lines, -36 lines 2 comments Download
M src/arm64/builtins-arm64.cc View 3 chunks +40 lines, -39 lines 0 comments Download
M src/arm64/simulator-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/simulator-arm64.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/execution.h View 2 chunks +3 lines, -16 lines 0 comments Download
M src/execution.cc View 7 chunks +52 lines, -149 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 3 chunks +34 lines, -34 lines 0 comments Download
M src/mips/builtins-mips.cc View 3 chunks +45 lines, -40 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 3 chunks +45 lines, -39 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/runtime/runtime-function.cc View 2 chunks +1 line, -32 lines 0 comments Download
M src/runtime/runtime-internal.cc View 2 chunks +36 lines, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 3 chunks +38 lines, -35 lines 0 comments Download

Messages

Total messages: 29 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360793002/20001
5 years, 3 months ago (2015-09-22 12:53:20 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/8256)
5 years, 3 months ago (2015-09-22 12:54:25 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360793002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360793002/40001
5 years, 3 months ago (2015-09-22 17:57:01 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_rel/builds/4864)
5 years, 3 months ago (2015-09-22 17:59:22 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360793002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360793002/60001
5 years, 3 months ago (2015-09-23 02:40:24 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/9836)
5 years, 3 months ago (2015-09-23 02:44:58 UTC) #15
Benedikt Meurer
Hey Jaro, Finally got rid of the horrible C++ magic around Invoke! Please take a ...
5 years, 3 months ago (2015-09-23 04:19:11 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360793002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360793002/100001
5 years, 3 months ago (2015-09-23 04:49:01 UTC) #21
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-23 05:10:42 UTC) #23
Jarin
lgtm https://codereview.chromium.org/1360793002/diff/100001/src/arm/builtins-arm.cc File src/arm/builtins-arm.cc (right): https://codereview.chromium.org/1360793002/diff/100001/src/arm/builtins-arm.cc#newcode1670 src/arm/builtins-arm.cc:1670: // 2. Construct of something that else, which ...
5 years, 3 months ago (2015-09-23 05:40:37 UTC) #24
Benedikt Meurer
https://codereview.chromium.org/1360793002/diff/100001/src/arm/builtins-arm.cc File src/arm/builtins-arm.cc (right): https://codereview.chromium.org/1360793002/diff/100001/src/arm/builtins-arm.cc#newcode1670 src/arm/builtins-arm.cc:1670: // 2. Construct of something that else, which might ...
5 years, 3 months ago (2015-09-23 05:41:54 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360793002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360793002/100001
5 years, 3 months ago (2015-09-23 05:42:22 UTC) #27
commit-bot: I haz the power
Committed patchset #1 (id:100001)
5 years, 3 months ago (2015-09-23 05:44:05 UTC) #28
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 05:44:20 UTC) #29
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/634d1d86d8e98584097c6cb548a68ecf705c44f7
Cr-Commit-Position: refs/heads/master@{#30874}

Powered by Google App Engine
This is Rietveld 408576698