Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1360763002: Sync m_lastRemainingAllocationSize on promptly freeing objects. (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync m_lastRemainingAllocationSize on promptly freeing objects. A heap's m_lastRemainingAllocationSize field is used to limit updating of heap allocated object size tracking. Upon promptly freeing objects, make sure it is synchronized so as to it avoid deviating across multiple such operations. R=haraken BUG=534423 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202634

Patch Set 1 #

Patch Set 2 : generalize + add comment #

Patch Set 3 : invert the logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M Source/platform/heap/HeapPage.cpp View 1 2 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sof
please take a look.
5 years, 3 months ago (2015-09-22 10:11:24 UTC) #2
haraken
Thanks for the fix! LGTM
5 years, 3 months ago (2015-09-22 11:22:44 UTC) #3
sof
On 2015/09/22 11:22:44, haraken wrote: > Thanks for the fix! LGTM Thanks - thinking this ...
5 years, 3 months ago (2015-09-22 12:03:10 UTC) #4
haraken
On 2015/09/22 12:03:10, sof wrote: > On 2015/09/22 11:22:44, haraken wrote: > > Thanks for ...
5 years, 3 months ago (2015-09-22 14:40:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360763002/40001
5 years, 3 months ago (2015-09-22 15:35:17 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 15:40:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202634

Powered by Google App Engine
This is Rietveld 408576698