Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: build/gyp_chromium

Issue 136073002: android: Set gcc_version in build/common.gypi instead of in envsetup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: gn Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/common.gypi ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/gyp_chromium
diff --git a/build/gyp_chromium b/build/gyp_chromium
index 3c804eb47560dcebdae62033062ca07264b5468d..d2d94625c931b050e8ca63d79b0eeefbd84f6b8c 100755
--- a/build/gyp_chromium
+++ b/build/gyp_chromium
@@ -137,7 +137,6 @@ def GetArgsStringForGN(supplemental_files):
# mac_strip_release=1 http://crbug.com/330301
# linux_dump_symbols=0 http://crbug.com/330300
# host_os=linux Probably can skip, GN knows the host OS.
- # gcc_version=46 Hopefully we can skip this and fix whatever uses it.
# order_text_section=<path> http://crbug.com/330299
# chromium_win_pch=0 http://crbug.com/297678
# clang_use_chrome_plugins=1 http://crbug.com/330298
« build/common.gypi ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698