Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1721)

Unified Diff: build/android/envsetup_functions.sh

Issue 136073002: android: Set gcc_version in build/common.gypi instead of in envsetup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: gn Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/common.gypi » ('j') | build/common.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/envsetup_functions.sh
diff --git a/build/android/envsetup_functions.sh b/build/android/envsetup_functions.sh
index 29cf44f19b8ca2288236859104f1c899bc8226b2..612e154cd2bb43ccd525342d9e435f14e19ce16c 100755
--- a/build/android/envsetup_functions.sh
+++ b/build/android/envsetup_functions.sh
@@ -44,9 +44,6 @@ common_vars_defines() {
esac
toolchain_version="4.6"
- # We directly set the gcc_version since we know what we use, and it should
- # be set to xx instead of x.x. Refer the output of compiler_version.py.
- gcc_version="46"
toolchain_target=$(basename \
${ANDROID_NDK_ROOT}/toolchains/${toolchain_arch}-${toolchain_version})
toolchain_path="${ANDROID_NDK_ROOT}/toolchains/${toolchain_target}"\
@@ -86,7 +83,6 @@ ${ANDROID_SDK_BUILD_TOOLS_VERSION}
# to canonicalize them (remove double '/', remove trailing '/', etc).
DEFINES="OS=android"
DEFINES+=" host_os=${host_os}"
- DEFINES+=" gcc_version=${gcc_version}"
if [[ -n "$CHROME_ANDROID_OFFICIAL_BUILD" ]]; then
DEFINES+=" branding=Chrome"
« no previous file with comments | « no previous file | build/common.gypi » ('j') | build/common.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698