Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1360723003: Non-Oilpan Memory: Fix HTMLViewSourceDocument and WebLeakDetector. (Closed)

Created:
5 years, 3 months ago by loyso (OOO)
Modified:
5 years, 2 months ago
Reviewers:
haraken, hajimehoshi, sof, Nico
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Non-Oilpan Memory: Fix HTMLViewSourceDocument and WebLeakDetector. 1) RenderViewImplTest.DidFailProvisionalLoadWithErrorForCancellation test was leaking with HTMLViewSourceDocument. 2) V8PerIsolateData::from(isolate)->ensureScriptRegexpContext() was leaking in WebLeakDetectorImpl::collectGarbageAndGetDOMCounts because of cycle. This is required by chromium part: https://codereview.chromium.org/1363523002 BUG=506433 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M Source/bindings/core/v8/V8PerIsolateData.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/core/v8/V8PerIsolateData.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/html/HTMLViewSourceDocument.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLViewSourceDocument.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/web/WebLeakDetector.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
loyso (OOO)
5 years, 3 months ago (2015-09-22 04:40:41 UTC) #2
haraken
LGTM
5 years, 2 months ago (2015-09-22 06:19:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360723003/1
5 years, 2 months ago (2015-09-22 06:22:06 UTC) #7
sof
+hajimehoshi for the ScriptRegexpContext part. lgtm also.
5 years, 2 months ago (2015-09-22 06:50:41 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-22 08:03:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202624

Powered by Google App Engine
This is Rietveld 408576698