Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1360723002: [crankshaft] Handle @@toStringTag accessor correctly for BuildCompareInstruction. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Handle @@toStringTag accessor correctly for BuildCompareInstruction. If @@toStringTag is an accessor property, we cannot assume that the result of calling Object.prototype.toString() for objects with the same map. R=adamk@chromium.org BUG=chromium:534200 LOG=n Committed: https://crrev.com/3d7c45371e26a3ca7b688ed73892cba44cb23c0d Cr-Commit-Position: refs/heads/master@{#30856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1 line) Patch
M src/hydrogen.cc View 2 chunks +6 lines, -1 line 0 comments Download
A test/mjsunit/compare-known-objects-tostringtag.js View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 3 months ago (2015-09-22 03:45:51 UTC) #1
Benedikt Meurer
Hey Adam, Thanks for the catch. Here's the fix. Please take a look. Thanks, Benedikt
5 years, 3 months ago (2015-09-22 03:46:20 UTC) #2
adamk
lgtm Thanks for the quick fix! Symbols everywhere in ES6.
5 years, 3 months ago (2015-09-22 03:51:08 UTC) #3
Benedikt Meurer
On 2015/09/22 03:51:08, adamk wrote: > Thanks for the quick fix! Symbols everywhere in ES6. ...
5 years, 3 months ago (2015-09-22 03:52:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360723002/1
5 years, 3 months ago (2015-09-22 03:52:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-22 04:07:58 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 04:08:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d7c45371e26a3ca7b688ed73892cba44cb23c0d
Cr-Commit-Position: refs/heads/master@{#30856}

Powered by Google App Engine
This is Rietveld 408576698