Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 13607006: rAc: don't clobber user input when accepting autofill popup suggestion (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index 2e0e7de7d4b7c4241b204cc342da4055c1fca18c..4d30363341be6be50ff3ec9cc8dbe97982217e6c 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -858,13 +858,13 @@ void AutofillDialogControllerImpl::EditClickedForSection(
scoped_ptr<DataModelWrapper> model = CreateWrapper(section);
model->FillInputs(inputs);
section_editing_state_[section] = true;
- view_->UpdateSection(section);
+ view_->UpdateSection(section, CLEAR_USER_INPUT);
}
void AutofillDialogControllerImpl::EditCancelledForSection(
DialogSection section) {
ResetManualInputForSection(section);
- view_->UpdateSection(section);
+ view_->UpdateSection(section, CLEAR_USER_INPUT);
}
gfx::Image AutofillDialogControllerImpl::IconForField(
@@ -1282,7 +1282,7 @@ void AutofillDialogControllerImpl::DidAcceptSuggestion(const string16& value,
for (size_t i = 0; i < arraysize(sections); ++i) {
DialogSection section = sections[i];
wrapper->FillInputs(MutableRequestedFieldsForSection(section));
- view_->UpdateSection(section);
+ view_->UpdateSection(section, KEEP_USER_INPUT);
}
metric_logger_.LogDialogPopupEvent(

Powered by Google App Engine
This is Rietveld 408576698