Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 13607006: rAc: don't clobber user input when accepting autofill popup suggestion (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: a couple more bugs Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index 197287dea24cf9f251051aab334906416f4acc41..aa820f32101e1bbe6f2f2190bde1fbf4b66fd86a 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -853,7 +853,7 @@ void AutofillDialogControllerImpl::EditClickedForSection(
scoped_ptr<DataModelWrapper> model = CreateWrapper(section);
model->FillInputs(inputs);
section_editing_state_[section] = true;
- view_->UpdateSection(section);
+ view_->UpdateSection(section, CLEAR_USER_INPUT);
}
void AutofillDialogControllerImpl::EditCancelledForSection(
@@ -862,7 +862,7 @@ void AutofillDialogControllerImpl::EditCancelledForSection(
for (size_t i = 0; i < inputs->size(); ++i)
(*inputs)[i].initial_value.clear();
section_editing_state_[section] = false;
- view_->UpdateSection(section);
+ view_->UpdateSection(section, CLEAR_USER_INPUT);
}
gfx::Image AutofillDialogControllerImpl::IconForField(
@@ -1271,7 +1271,7 @@ void AutofillDialogControllerImpl::DidAcceptSuggestion(const string16& value,
FillInputFromFormGroup(
form_group,
MutableRequestedFieldsForSection(section_showing_popup_));
- view_->UpdateSection(section_showing_popup_);
+ view_->UpdateSection(section_showing_popup_, KEEP_USER_INPUT);
metric_logger_.LogDialogPopupEvent(
dialog_type_, AutofillMetrics::DIALOG_POPUP_FORM_FILLED);

Powered by Google App Engine
This is Rietveld 408576698