rAc: don't clobber user input when accepting autofill popup suggestion

chrome/browser/ui/autofill/autofill_dialog_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_VIEW_H_
 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_VIEW_H_
 
 #include "chrome/browser/ui/autofill/autofill_dialog_controller.h"
 
 namespace content {
@@ skipping 17 matching lines @@
   // Called when a different notification is available.
   virtual void UpdateNotificationArea() = 0;
 
   // Called when account details may have changed (user logs in to GAIA, creates
   // a new account, etc.).
   virtual void UpdateAccountChooser() = 0;
 
   // Updates the button strip based on the current controller state.
   virtual void UpdateButtonStrip() = 0;
 
-  // Called when the contents of a section have changed.
-  virtual void UpdateSection(DialogSection section) = 0;
+  // Called when the contents of a section have changed. If |clear_user_input|,
+  // is true, the view should also clobber all manual inputs. Otherwise,
+  // previous user input should be respected.
+  virtual void UpdateSection(DialogSection section, bool clear_user_input) = 0;

[Ilya Sherman, 2013/04/04 03:59:55]

nit: If you keep this method, please use an enumerated constant rather than a
boolean for the type of the second variable.  As is, call sites are quite hard
to understand at a glance.

[Ilya Sherman, 2013/04/04 23:11:02]

^^^

[Evan Stade, 2013/04/05 23:24:01]

Done.

 
   // Fills |output| with data the user manually input.
   virtual void GetUserInput(DialogSection section, DetailOutputMap* output) = 0;
 
   // Gets the CVC value the user typed to go along with the stored credit card
   // data. If the user is inputing credit card data from scratch, this is not
   // relevant.
   virtual string16 GetCvc() = 0;
 
   // Returns the state of the "use billing address for shipping" checkbox.
@@ skipping 26 matching lines @@
   virtual void CancelForTesting() = 0;
 
   // Factory function to create the dialog (implemented once per view
   // implementation). |controller| will own the created dialog.
   static AutofillDialogView* Create(AutofillDialogController* controller);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_VIEW_H_