Remove SkNEW and SkDELETE macros

Remove SkNEW and SkDELETE macros

This CL removes the uses of SkNEW that have resprouted since commit
385fe4d, and removes the macros entirely now that Android and Chromium
have been cleaned up to no longer depend on them.

A bunch of files implicitly depend on #include <new> from SkPostConfig.h
still though, so keep that for now.  To be fixed in a followup CL.

[mtklein mucking around]
Only public API removed.
TBR=reed@google.com

Committed: https://skia.googlesource.com/skia/+/106b12427e642d067dd5b48664eb693653853583

[mdempsky, 2015-09-22 00:38:31]

mdempsky@chromium.org changed reviewers:
+ mtklein@chromium.org

[mtklein, 2015-09-22 12:52:47]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-22 12:52:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1360653004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1360653004/20001

[mtklein, 2015-09-22 12:52:55]

https://codereview.chromium.org/1360653004/diff/20001/include/core/SkImageGen...
File include/core/SkImageGenerator.h (left):

https://codereview.chromium.org/1360653004/diff/20001/include/core/SkImageGen...
include/core/SkImageGenerator.h:34: *  SkDELETE() on the generator.  Therefore,
generator should be
Let's leave this here with delete and new.  A lot of stuff in Skia implicitly
uses malloc / free, so it's a useful note still that it needs to be allocated
with new.

https://codereview.chromium.org/1360653004/diff/20001/include/core/SkPostConf...
File include/core/SkPostConfig.h (right):

https://codereview.chromium.org/1360653004/diff/20001/include/core/SkPostConf...
include/core/SkPostConfig.h:103: // TODO(mdempsky): Move elsewhere as
appropriate.
bungeman's got iwyu working for Skia.  It might be able to do this for you.

[commit-bot: I haz the power, 2015-09-22 12:57:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-22 12:57:46]

Dry run: This issue passed the CQ dry run.

[mdempsky, 2015-09-22 13:00:08]

https://codereview.chromium.org/1360653004/diff/20001/include/core/SkImageGen...
File include/core/SkImageGenerator.h (left):

https://codereview.chromium.org/1360653004/diff/20001/include/core/SkImageGen...
include/core/SkImageGenerator.h:34: *  SkDELETE() on the generator.  Therefore,
generator should be
On 2015/09/22 12:52:55, mtklein wrote:
> Let's leave this here with delete and new.  A lot of stuff in Skia implicitly
> uses malloc / free, so it's a useful note still that it needs to be allocated
> with new.

Good point, done.

https://codereview.chromium.org/1360653004/diff/20001/include/core/SkPostConf...
File include/core/SkPostConfig.h (right):

https://codereview.chromium.org/1360653004/diff/20001/include/core/SkPostConf...
include/core/SkPostConfig.h:103: // TODO(mdempsky): Move elsewhere as
appropriate.
On 2015/09/22 12:52:55, mtklein wrote:
> bungeman's got iwyu working for Skia.  It might be able to do this for you.

Thanks, I'll look into that.

[mtklein, 2015-09-22 13:05:22]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-09-22 13:05:27]

lgtm

[commit-bot: I haz the power, 2015-09-22 13:05:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1360653004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1360653004/40001

[commit-bot: I haz the power, 2015-09-22 13:10:39]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/106b12427e642d067dd5b48664eb693653853583