Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 136063002: Use a RefPtr to store implementation in QualifiedName (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Use a RefPtr to store implementation in QualifiedName Use a RefPtr to store implementation in QualifiedName instead of handling ref-counting manually. This makes the code shorter / simpler. R=eseidel, esprehn BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -26 lines) Patch
M Source/core/dom/QualifiedName.h View 2 chunks +9 lines, -12 lines 0 comments Download
M Source/core/dom/QualifiedName.cpp View 1 chunk +1 line, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 11 months ago (2014-01-12 22:34:16 UTC) #1
esprehn
Lgtm, looks reasonable to me. Any idea why it didn't before? To unsubscribe from this ...
6 years, 11 months ago (2014-01-13 08:51:27 UTC) #2
Inactive
On 2014/01/13 08:51:27, esprehn wrote: > Lgtm, looks reasonable to me. Any idea why it ...
6 years, 11 months ago (2014-01-13 14:31:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/136063002/1
6 years, 11 months ago (2014-01-13 19:55:15 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-13 20:01:01 UTC) #5
Message was sent while issue was closed.
Change committed as 164998

Powered by Google App Engine
This is Rietveld 408576698