Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: src/compiler/arm64/code-generator-arm64.cc

Issue 1360603003: [arm64] Implement Float(32|64)(Min|Max) using fcsel. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: More local solution, as suggested. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/arm64/code-generator-arm64.cc
diff --git a/src/compiler/arm64/code-generator-arm64.cc b/src/compiler/arm64/code-generator-arm64.cc
index 52d61367a49c3c63a6732626cf92ada2ba4bc795..521ed02a3a8cbab0a0ca6b6aed780445c7a4fe53 100644
--- a/src/compiler/arm64/code-generator-arm64.cc
+++ b/src/compiler/arm64/code-generator-arm64.cc
@@ -821,13 +821,17 @@ void CodeGenerator::AssembleArchInstruction(Instruction* instr) {
__ Fdiv(i.OutputFloat32Register(), i.InputFloat32Register(0),
i.InputFloat32Register(1));
break;
- case kArm64Float32Max:
- __ Fmax(i.OutputFloat32Register(), i.InputFloat32Register(0),
- i.InputFloat32Register(1));
+ case kArm64Float32TernaryMax:
+ // (b < a) ? a : b
+ __ Fcmp(i.InputFloat32Register(1), i.InputFloat32Register(0));
+ __ Fcsel(i.OutputFloat32Register(), i.InputFloat32Register(0),
+ i.InputFloat32Register(1), lo);
break;
- case kArm64Float32Min:
- __ Fmin(i.OutputFloat32Register(), i.InputFloat32Register(0),
- i.InputFloat32Register(1));
+ case kArm64Float32TernaryMin:
+ // (a < b) ? a : b
+ __ Fcmp(i.InputFloat32Register(0), i.InputFloat32Register(1));
+ __ Fcsel(i.OutputFloat32Register(), i.InputFloat32Register(0),
+ i.InputFloat32Register(1), lo);
break;
case kArm64Float32Abs:
__ Fabs(i.OutputFloat32Register(), i.InputFloat32Register(0));
@@ -872,13 +876,17 @@ void CodeGenerator::AssembleArchInstruction(Instruction* instr) {
0, 2);
break;
}
- case kArm64Float64Max:
- __ Fmax(i.OutputDoubleRegister(), i.InputDoubleRegister(0),
- i.InputDoubleRegister(1));
+ case kArm64Float64TernaryMax:
+ // (b < a) ? a : b
+ __ Fcmp(i.InputDoubleRegister(1), i.InputDoubleRegister(0));
+ __ Fcsel(i.OutputDoubleRegister(), i.InputDoubleRegister(0),
+ i.InputDoubleRegister(1), lo);
break;
- case kArm64Float64Min:
- __ Fmin(i.OutputDoubleRegister(), i.InputDoubleRegister(0),
- i.InputDoubleRegister(1));
+ case kArm64Float64TernaryMin:
+ // (a < b) ? a : b
+ __ Fcmp(i.InputDoubleRegister(0), i.InputDoubleRegister(1));
+ __ Fcsel(i.OutputDoubleRegister(), i.InputDoubleRegister(0),
+ i.InputDoubleRegister(1), lo);
break;
case kArm64Float64Abs:
__ Fabs(i.OutputDoubleRegister(), i.InputDoubleRegister(0));
« no previous file with comments | « no previous file | src/compiler/arm64/instruction-codes-arm64.h » ('j') | src/compiler/arm64/instruction-codes-arm64.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698