Issue 13606: Some Cleanup converting CRect to gfx::Rect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13606: Some Cleanup converting CRect to gfx::Rect (Closed)

Created:
12 years ago by Mohamed Mansour (USE mhm)

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting, Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Some Cleanup converting CRect to gfx::Rect BUG=2186 (http://crbug.com/2186)

Patch Set 2 : '' #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	chrome/browser/views/download_tab_view.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

http://codereview.chromium.org/13606/diff/1/2 File chrome/browser/views/download_tab_view.cc (right): http://codereview.chromium.org/13606/diff/1/2#newcode188 Line 188: SetFocusable(true); Did you mean to add this?

12 years ago (2008-12-07 02:05:20 UTC) #2

Mohamed Mansour (USE mhm)

On 2008/12/07 02:05:20, pkasting wrote: Oh snap, sorry, I was fixing another bug, I thought ...

12 years ago (2008-12-07 02:21:38 UTC) #3