Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1360553003: [heap] Sort declarations for MemoryChunk. (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Sort declarations for MemoryChunk. R=hpayer@chromium.org BUG= Committed: https://crrev.com/41b8e10e1ac0dac50384bc9ef1d141fae7e5c67b Cr-Commit-Position: refs/heads/master@{#30850}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -164 lines) Patch
M src/heap/spaces.h View 1 12 chunks +150 lines, -162 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Lippautz
Sorting MemoryChunk (+ prev and next pointers are now AtomicValue's)
5 years, 3 months ago (2015-09-21 09:39:32 UTC) #2
Hannes Payer (out of office)
LGTM. It would be nice to check which methods do not have to be public, ...
5 years, 3 months ago (2015-09-21 12:58:49 UTC) #3
Michael Lippautz
Moved one method to private section as all the others are unfortunately in use by ...
5 years, 3 months ago (2015-09-21 13:38:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360553003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360553003/20001
5 years, 3 months ago (2015-09-21 13:38:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-21 14:03:48 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 14:04:07 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/41b8e10e1ac0dac50384bc9ef1d141fae7e5c67b
Cr-Commit-Position: refs/heads/master@{#30850}

Powered by Google App Engine
This is Rietveld 408576698