Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: ios/web/web_state/ui/crw_ui_web_view_web_controller.mm

Issue 1360543004: Manually fetch favicons after hash changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_ui_web_view_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_ui_web_view_web_controller.mm b/ios/web/web_state/ui/crw_ui_web_view_web_controller.mm
index 5efb858d0e6f8282bb24ef10662775e5e9ee5150..75cd9f2c40390588c7b8811ad21441bc8847ecb9 100644
--- a/ios/web/web_state/ui/crw_ui_web_view_web_controller.mm
+++ b/ios/web/web_state/ui/crw_ui_web_view_web_controller.mm
@@ -821,6 +821,15 @@ const size_t kMaxMessageQueueSize = 262144;
referrer:[self currentReferrer]];
}
+ // Fetch the favicons for the new page.
+ // TODO(kkhorimoto): Consolidate favicon fetching into a single location.
+ // http://crbug.com/534573
+ NSString *const kGetFaviconsScript =
+ @"__gCrWeb.message.invokeOnHost("
Eugene But (OOO till 7-30) 2015/09/21 21:32:43 This approach is very fragile and will break if f.
kkhorimoto 2016/01/30 00:47:01 Done.
+ " {'command' : 'document.favicons',"
+ " 'favicons': __gCrWeb.common.getFavicons()});";
+ web::EvaluateJavaScript(_uiWebView, kGetFaviconsScript, nil);
+
[super webPageChanged];
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698