gpu/tools/compositor_model_bench/shaders.cc - Issue 1360513002: Cleanup: Pass std::string as const reference from gpu/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/tools/compositor_model_bench/shaders.cc

Issue 1360513002: Cleanup: Pass std::string as const reference from gpu/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass func_name as const char* in GLES2DecoderImpl::ProduceTextureRef Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/tools/compositor_model_bench/shaders.cc

diff --git a/gpu/tools/compositor_model_bench/shaders.cc b/gpu/tools/compositor_model_bench/shaders.cc

index 5559e73a558d526707ef18b7298739b8fbdb43c3..66f5aac63e2b4cfbeeb4a4b84678edec22cc751e 100644

--- a/gpu/tools/compositor_model_bench/shaders.cc

+++ b/gpu/tools/compositor_model_bench/shaders.cc

@@ -81,7 +81,7 @@ static void TranslateInPlace(float* m, float tx, float ty, float tz) {

///////////////////////////////////////////////////////////////////////////////

-ShaderID ShaderIDFromString(std::string name) {

+ShaderID ShaderIDFromString(const std::string& name) {

if (name == "VertexShaderPosTexYUVStretch")

return VERTEX_SHADER_POS_TEX_YUV_STRETCH;

if (name == "VertexShaderPosTex")

« no previous file with comments | « gpu/tools/compositor_model_bench/shaders.h ('k') | no next file » | no next file with comments »