Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1360403002: Revert of [es6] Introduce spec compliant IsConstructor. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Jarin, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] Introduce spec compliant IsConstructor. (patchset #2 id:20001 of https://codereview.chromium.org/1358423002/ ) Reason for revert: Failed on Fuzzer and MIPS bot. Original issue's description: > [es6] Introduce spec compliant IsConstructor. > > There was already a bit on the Map named "function with prototype", > which basically meant that the Map was a map for a JSFunction that could > be used as a constructor. Now this CL generalizes that bit to > IsConstructor, which says that whatever (Heap)Object you are looking at > can be used as a constructor (i.e. the bit is also set for bound > functions that can be used as constructors and proxies that have a > [[Construct]] internal method). > > This way we have a single chokepoint for IsConstructor checking, which > allows us to get rid of the various ways in which we tried to guess > whether something could be used as a constructor or not. > > Drive-by-fix: Renamed IsConstructor on FunctionKind to > IsClassConstructor to resolve the weird name clash, and the > IsClassConstructor name also matches the spec. > > R=jarin@chromium.org, rossberg@chromium.org > BUG=v8:4430 > LOG=n > > Committed: https://crrev.com/8de4d9351df4cf66c8a128d561a6e331d196be54 > Cr-Commit-Position: refs/heads/master@{#30900} TBR=jarin@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4430 Committed: https://crrev.com/656ebdce8d2cfa1ba1d37686b20785321f1874b9 Cr-Commit-Position: refs/heads/master@{#30901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -326 lines) Patch
M src/accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/api-natives.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/builtins-arm.cc View 2 chunks +26 lines, -41 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 2 chunks +25 lines, -40 lines 0 comments Download
M src/bootstrapper.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/builtins.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/contexts.h View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/globals.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +25 lines, -40 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 2 chunks +28 lines, -43 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 2 chunks +28 lines, -43 lines 0 comments Download
M src/objects.h View 6 chunks +8 lines, -10 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 4 chunks +12 lines, -18 lines 0 comments Download
M src/parser.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M src/preparser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/preparser.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/runtime/runtime-function.cc View 3 chunks +25 lines, -9 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/scopes.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/scopes.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +26 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Created Revert of [es6] Introduce spec compliant IsConstructor.
5 years, 3 months ago (2015-09-24 05:26:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360403002/1
5 years, 3 months ago (2015-09-24 05:26:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 05:26:55 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 05:27:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/656ebdce8d2cfa1ba1d37686b20785321f1874b9
Cr-Commit-Position: refs/heads/master@{#30901}

Powered by Google App Engine
This is Rietveld 408576698