Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 13604006: [Android] Remove emma coverage logic for instrumentation tests. (Closed)

Created:
7 years, 8 months ago by frankf
Modified:
7 years, 8 months ago
Reviewers:
craigdh
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

[Android] Remove emma coverage logic for instrumentation tests. We don't use coverage metrics, and this is just polluting the code. BUG=172090 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192364

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -101 lines) Patch
M build/android/pylib/host_driven/java_unittest_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/host_driven/python_test_base.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/host_driven/run_python_tests.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/instrumentation/dispatch.py View 2 chunks +3 lines, -5 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 8 chunks +3 lines, -91 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
frankf
7 years, 8 months ago (2013-04-04 02:07:36 UTC) #1
craigdh
On 2013/04/04 02:07:36, frankf wrote: LFATM. (lgtm.)
7 years, 8 months ago (2013-04-04 16:29:51 UTC) #2
craigdh
Also, remember to remove tools from run_java_tests.py in chromedriver.
7 years, 8 months ago (2013-04-04 16:39:45 UTC) #3
frankf
7 years, 8 months ago (2013-04-04 18:04:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r192364 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698