Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1360373002: [Chromecast] Disable libpci on Chromecast builds by default. (Closed)

Created:
5 years, 3 months ago by slan
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, no sievers
CC:
chromium-reviews, piman+watch_chromium.org, halliwell
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Disable libpci on Chromecast builds by default. Cast does not need libpci. Disable by default. This does not affect non-Cast builds, as is_chromecast defaults to false. BUG=516899 Committed: https://crrev.com/0d1a024e90e8b16f30268bc6103c2bc6212f90f9 Cr-Commit-Position: refs/heads/master@{#350723}

Patch Set 1 #

Patch Set 2 : Update GYP to default to false for cast builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M build/common.gypi View 1 1 chunk +8 lines, -3 lines 0 comments Download
M gpu/config/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (8 generated)
slan
Chromecast needs to disable libpci by default. Thanks for taking a look.
5 years, 3 months ago (2015-09-24 14:12:06 UTC) #2
no sievers
lgtm
5 years, 3 months ago (2015-09-24 17:57:04 UTC) #3
no sievers
On 2015/09/24 17:57:04, sievers wrote: > lgtm sorry, plz update gyp also
5 years, 3 months ago (2015-09-24 17:57:22 UTC) #4
slan
On 2015/09/24 17:57:22, sievers wrote: > On 2015/09/24 17:57:04, sievers wrote: > > lgtm > ...
5 years, 3 months ago (2015-09-24 18:32:39 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360373002/20001
5 years, 3 months ago (2015-09-24 18:35:36 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-24 20:20:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360373002/20001
5 years, 3 months ago (2015-09-24 21:43:02 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/103588)
5 years, 3 months ago (2015-09-24 21:55:40 UTC) #14
slan
+dpranke@ for common.gypi Dirk, this sets use_libpci to false for Cast builds by default. PTAL.
5 years, 3 months ago (2015-09-24 23:01:18 UTC) #16
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-24 23:03:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360373002/20001
5 years, 3 months ago (2015-09-25 00:49:17 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-25 00:57:13 UTC) #20
commit-bot: I haz the power
5 years, 3 months ago (2015-09-25 00:58:05 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0d1a024e90e8b16f30268bc6103c2bc6212f90f9
Cr-Commit-Position: refs/heads/master@{#350723}

Powered by Google App Engine
This is Rietveld 408576698