Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 136033007: [NaCl SDK Docs] Simplify PPAPI documentation generation. (Closed)

Created:
6 years, 11 months ago by binji
Modified:
6 years, 11 months ago
Reviewers:
Sam Clegg, Andy
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, raymes+watch_chromium.org, yzshen+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, native-client-reviews_googlegroups.com, noelallen1, ihf+watch_chromium.org
Visibility:
Public.

Description

[NaCl SDK Docs] Simplify PPAPI documentation generation. * Modified chrome_sidenav.json to point to the correct locations. * Added new template Doxygen config files for PPAPI C/C++ to the native_client_sdk directory. * Copied doxy_cleanup.py from ppapi/c/documentation, and moved it to native_client_sdk, with some cleanup * Modified doxygen header/footer to generate for chromesite * Added generate_docs.py script. This automates nearly all of the doxygen documentation generation: gets the current stable/beta/dev branches, downloads ppapi via SVN, runs doxygen, runs doxy_cleanup, and generates ReST files for reference indexes. No tryjobs because this is a documentation-only change. BUG=none R=awatson@chromium.org, sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245362

Patch Set 1 #

Total comments: 7

Patch Set 2 : feedback #

Patch Set 3 : revert changes to ppapi/c/documentation/ #

Patch Set 4 : add license to stylesheet #

Patch Set 5 : 2013 -> 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2373 lines, -74 lines) Patch
M chrome/common/extensions/docs/templates/json/chrome_sidenav.json View 1 chunk +14 lines, -18 lines 0 comments Download
A native_client_sdk/src/doc/doxygen/Doxyfile.c.template View 1 chunk +75 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/doxygen/Doxyfile.cpp.template View 1 chunk +76 lines, -0 lines 0 comments Download
A + native_client_sdk/src/doc/doxygen/doxy_cleanup.py View 1 4 chunks +121 lines, -44 lines 0 comments Download
A native_client_sdk/src/doc/doxygen/footer.html View 1 chunk +1 line, -0 lines 0 comments Download
A native_client_sdk/src/doc/doxygen/generate_docs.py View 1 1 chunk +223 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/doxygen/header.html View 1 chunk +3 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/doxygen/rst_index.py View 1 1 chunk +256 lines, -0 lines 0 comments Download
A + native_client_sdk/src/doc/doxygen/stylesheet.css View 1 2 3 4 2 chunks +5 lines, -1 line 0 comments Download
M native_client_sdk/src/doc/faq.rst View 1 chunk +1 line, -1 line 0 comments Download
A native_client_sdk/src/doc/pepper_beta/c/index.rst View 1 1 chunk +283 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/pepper_beta/cpp/index.rst View 1 1 chunk +218 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/pepper_beta/index.rst View 1 1 chunk +19 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/pepper_dev/c/index.rst View 1 1 chunk +299 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/pepper_dev/cpp/index.rst View 1 1 chunk +234 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/pepper_dev/index.rst View 1 1 chunk +19 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/pepper_stable/c/index.rst View 1 1 chunk +283 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/pepper_stable/cpp/index.rst View 1 1 chunk +218 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/pepper_stable/index.rst View 1 1 chunk +19 lines, -0 lines 0 comments Download
D native_client_sdk/src/doc/peppercpp/index.rst View 1 chunk +0 lines, -9 lines 0 comments Download
M native_client_sdk/src/doc/sitemap.rst View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
binji
6 years, 11 months ago (2014-01-15 22:32:24 UTC) #1
Sam Clegg
lgtm https://codereview.chromium.org/136033007/diff/1/native_client_sdk/src/doc/doxygen/generate_docs.py File native_client_sdk/src/doc/doxygen/generate_docs.py (right): https://codereview.chromium.org/136033007/diff/1/native_client_sdk/src/doc/doxygen/generate_docs.py#newcode63 native_client_sdk/src/doc/doxygen/generate_docs.py:63: pass Why ignore these errors?
6 years, 11 months ago (2014-01-15 23:22:58 UTC) #2
binji
https://codereview.chromium.org/136033007/diff/1/native_client_sdk/src/doc/doxygen/generate_docs.py File native_client_sdk/src/doc/doxygen/generate_docs.py (right): https://codereview.chromium.org/136033007/diff/1/native_client_sdk/src/doc/doxygen/generate_docs.py#newcode63 native_client_sdk/src/doc/doxygen/generate_docs.py:63: pass On 2014/01/15 23:22:59, Sam Clegg wrote: > Why ...
6 years, 11 months ago (2014-01-15 23:56:16 UTC) #3
Sam Clegg
On 2014/01/15 23:56:16, binji wrote: > https://codereview.chromium.org/136033007/diff/1/native_client_sdk/src/doc/doxygen/generate_docs.py > File native_client_sdk/src/doc/doxygen/generate_docs.py (right): > > https://codereview.chromium.org/136033007/diff/1/native_client_sdk/src/doc/doxygen/generate_docs.py#newcode63 > ...
6 years, 11 months ago (2014-01-16 02:25:37 UTC) #4
Andy
LGTM. A couple of comments inline. https://codereview.chromium.org/136033007/diff/1/native_client_sdk/src/doc/pepper_beta/c/index.rst File native_client_sdk/src/doc/pepper_beta/c/index.rst (right): https://codereview.chromium.org/136033007/diff/1/native_client_sdk/src/doc/pepper_beta/c/index.rst#newcode8 native_client_sdk/src/doc/pepper_beta/c/index.rst:8: Can we add ...
6 years, 11 months ago (2014-01-16 09:51:38 UTC) #5
binji
https://codereview.chromium.org/136033007/diff/1/native_client_sdk/src/doc/doxygen/generate_docs.py File native_client_sdk/src/doc/doxygen/generate_docs.py (right): https://codereview.chromium.org/136033007/diff/1/native_client_sdk/src/doc/doxygen/generate_docs.py#newcode63 native_client_sdk/src/doc/doxygen/generate_docs.py:63: pass On 2014/01/15 23:56:16, binji wrote: > On 2014/01/15 ...
6 years, 11 months ago (2014-01-16 22:27:07 UTC) #6
binji
6 years, 11 months ago (2014-01-16 22:55:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 manually as r245362 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698