Issue 136033003: Remove unused functions: HitTestResult::targetFrame, and Element::target.

Issue 136033003: Remove unused functions: HitTestResult::targetFrame, and Element::target. (Closed)

Created:
6 years, 11 months ago by tkent

Modified:
6 years, 11 months ago

Reviewers:
yosin_UTC9

CC:
blink-reviews, krit, gavinp+prerender_chromium.org, zoltan1, sof, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), adamk+blink_chromium.org, jchaffraix+rendering, pdr, bemjb+rendering_chromium.org, Stephen Chennney, rwlbuis, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove unused functions: HitTestResult::targetFrame, and Element::target. They are unused. Note: We just make HTMLAnchorElement::target non-virtual because it is used twice in HTMLAnchorElement.cpp. BUG=none TEST=none; no behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165123

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -44 lines)			Patch
M	Source/core/dom/Element.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLAnchorElement.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/html/HTMLAreaElement.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLAreaElement.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/core/html/HTMLBaseElement.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLBaseElement.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/core/html/HTMLFormElement.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLFormElement.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/core/html/HTMLLinkElement.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLLinkElement.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/core/rendering/HitTestResult.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/rendering/HitTestResult.cpp	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	Source/core/svg/SVGAElement.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGAElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yosin_UTC9

LGTM Thanks for cleanup. I'm wonder how you found this... ;-)

6 years, 11 months ago (2014-01-15 07:24:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/136033003/1

6 years, 11 months ago (2014-01-15 08:16:59 UTC) #3

Message was sent while issue was closed.

Change committed as 165123

Expand Messages | Collapse Messages