Add "Cast..." to overflow and contextual menus.

Add "Cast..." to overflow and contextual menus.

This changes adds a new entry point for the Media Router dialog by adding a "Cast..." menu item into the overflow/wrench menu as well as page/audio/video contextual menus.

This new menu item is currently only surfaced if Media Router is enabled (--enable-media-router) and if the user is not in Incognito mode. Once Media Router is re-enabled for Incognito, that check should be removed.

BUG=534841
Committed: https://crrev.com/45cbfc953362be66bb1813b38d3c0d76a68fe9a0
Cr-Commit-Position: refs/heads/master@{#351184}

[apacible, 2015-09-24 00:48:55]

Patchset #1 (id:1) has been deleted

[apacible, 2015-09-24 01:34:09]

Patchset #1 (id:20001) has been deleted

[apacible, 2015-09-25 17:01:41]

Patchset #1 (id:40001) has been deleted

[apacible, 2015-09-25 18:03:40]

Patchset #1 (id:60001) has been deleted

[apacible, 2015-09-25 18:12:46]

Patchset #1 (id:80001) has been deleted

[apacible, 2015-09-25 18:47:42]

Patchset #1 (id:100001) has been deleted

[apacible, 2015-09-25 18:47:46]

Patchset #1 (id:120001) has been deleted

[apacible, 2015-09-25 21:40:48]

Patchset #1 (id:140001) has been deleted

[apacible, 2015-09-25 21:55:45]

apacible@chromium.org changed reviewers:
+ cpu@chromium.org

[apacible, 2015-09-25 21:58:38]

PTAL, thanks!

+cpu for all files

Screenshots:
MR enabled AND not Incognito:
LTR:
- Overflow menu: https://screenshot.googleplex.com/BhzovEdOu4E.png
- Contextual menu (page content):
https://screenshot.googleplex.com/TLyssReL7WO.png
- Contextual menu (audio/video):
https://screenshot.googleplex.com/ZMeAEZkUX7S.png
- Contextual menu (custom): https://screenshot.googleplex.com/REVTBxrL7fN.png

RTL:
- Overflow menu: https://screenshot.googleplex.com/ozsVHfFQdj0.png
- Contextual menu (page content):
https://screenshot.googleplex.com/rBXOPXZsq0S.png
- Contextual menu (audio/video):
https://screenshot.googleplex.com/7VH7wWLMzmt.png
- Contextual menu (custom): https://screenshot.googleplex.com/7zPQXVdxAgv.png

MR not enabled OR Incognito:
LTR:
- Overflow menu: https://screenshot.googleplex.com/OwsOSywm8YG.png
- Contextual menu (page content):
https://screenshot.googleplex.com/bHRsfkZGVRh.png
- Contextual menu (audio/video):
https://screenshot.googleplex.com/CBPDgRunxjV.png
- Contextual menu (custom): https://screenshot.googleplex.com/418MTH3YwMC.png

RTL:
- Overflow menu: https://screenshot.googleplex.com/gtHPZrd4YRO.png
- Contextual menu (page content):
https://screenshot.googleplex.com/e49H3BubfCF.png
- Contextual menu (audio/video):
https://screenshot.googleplex.com/uFJZNZmcf0q.png
- Contextual menu (custom): https://screenshot.googleplex.com/3g4oN5HoK6V.png

[cpu_(ooo_6.6-7.5), 2015-09-25 22:47:38]

Jennifer, can you have a UI/UX person OK the screenshots in the bug?

[apacible, 2015-09-25 22:51:06]

apacible@chromium.org changed reviewers:
+ jonnymack@chromium.org

[apacible, 2015-09-25 22:51:07]

+jonnymack for UX

[jonnymack, 2015-09-25 22:54:09]

On 2015/09/25 22:51:07, apacible wrote:
> +jonnymack for UX

LGTM

[cpu_(ooo_6.6-7.5), 2015-09-28 17:39:17]

lgtm with changes

https://codereview.chromium.org/1360323002/diff/110013/chrome/browser/ui/brow...
File chrome/browser/ui/browser_commands.cc (right):

https://codereview.chromium.org/1360323002/diff/110013/chrome/browser/ui/brow...
chrome/browser/ui/browser_commands.cc:919: // Do not allow casting when there is
an active modal dialog.
why so? if there is a bug open reference the bug.

https://codereview.chromium.org/1360323002/diff/110013/chrome/browser/ui/brow...
chrome/browser/ui/browser_commands.cc:924: DCHECK(switches::MediaRouterEnabled()
&&
DCHECK(CanRouteMedia()) instead.

[apacible, 2015-09-28 18:28:36]

https://codereview.chromium.org/1360323002/diff/110013/chrome/browser/ui/brow...
File chrome/browser/ui/browser_commands.cc (right):

https://codereview.chromium.org/1360323002/diff/110013/chrome/browser/ui/brow...
chrome/browser/ui/browser_commands.cc:919: // Do not allow casting when there is
an active modal dialog.
On 2015/09/28 17:39:17, cpu wrote:
> why so? if there is a bug open reference the bug.

Updated comment.

https://codereview.chromium.org/1360323002/diff/110013/chrome/browser/ui/brow...
chrome/browser/ui/browser_commands.cc:924: DCHECK(switches::MediaRouterEnabled()
&&
On 2015/09/28 17:39:17, cpu wrote:
> DCHECK(CanRouteMedia()) instead.

Done.

[apacible, 2015-09-28 18:35:48]

Patchset #3 (id:190001) has been deleted

[apacible, 2015-09-28 19:23:34]

The CQ bit was checked by apacible@chromium.org

[apacible, 2015-09-28 19:23:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
jonnymack@chromium.org, cpu@chromium.org
Link to the patchset: https://codereview.chromium.org/1360323002/#ps170001
(title: "Changes per cpu@'s comments.")

[commit-bot: I haz the power, 2015-09-28 19:26:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1360323002/170001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1360323002/170001

[commit-bot: I haz the power, 2015-09-28 19:38:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 19:38:21]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[apacible, 2015-09-28 21:41:12]

The CQ bit was checked by apacible@chromium.org

[apacible, 2015-09-28 21:41:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
jonnymack@chromium.org, cpu@chromium.org
Link to the patchset: https://codereview.chromium.org/1360323002/#ps210001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-09-28 21:43:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1360323002/210001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1360323002/210001

[commit-bot: I haz the power, 2015-09-28 22:45:50]

Committed patchset #3 (id:210001)

[commit-bot: I haz the power, 2015-09-28 22:47:00]

Patchset 3 (id:??) landed as
https://crrev.com/45cbfc953362be66bb1813b38d3c0d76a68fe9a0
Cr-Commit-Position: refs/heads/master@{#351184}