Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1360313004: Also generate R.java files for app-as-shared-lib (Closed)

Created:
5 years, 3 months ago by michaelbai
Modified:
5 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Also generate R.java files for app-as-shared-lib BUG=532598 Committed: https://crrev.com/6b8f86920bd645f0fae7600fc38bf9359c9fdec7 Cr-Commit-Position: refs/heads/master@{#351192}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/gyp/process_resources.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
michaelbai
5 years, 3 months ago (2015-09-24 04:43:09 UTC) #2
michaelbai
On 2015/09/24 04:43:09, michaelbai wrote: ping
5 years, 2 months ago (2015-09-25 16:52:39 UTC) #3
jbudorick
lgtm
5 years, 2 months ago (2015-09-28 17:45:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360313004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360313004/1
5 years, 2 months ago (2015-09-28 20:39:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/102837) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 2 months ago (2015-09-28 20:45:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360313004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360313004/20001
5 years, 2 months ago (2015-09-28 21:09:50 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 22:51:54 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 22:53:49 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b8f86920bd645f0fae7600fc38bf9359c9fdec7
Cr-Commit-Position: refs/heads/master@{#351192}

Powered by Google App Engine
This is Rietveld 408576698