Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: net/log/net_log_capture_mode.h

Issue 1360253002: Log GOAWAY frame debug data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re: #12. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_log_util_unittest.cc ('k') | net/log/net_log_capture_mode.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/log/net_log_capture_mode.h
diff --git a/net/log/net_log_capture_mode.h b/net/log/net_log_capture_mode.h
index e08e2ad436ae84474a70d0fb7edd69cd9cc240ca..8865e5f11ff18449e71c12fb3297e3ee98d5dced 100644
--- a/net/log/net_log_capture_mode.h
+++ b/net/log/net_log_capture_mode.h
@@ -32,6 +32,7 @@ class NET_EXPORT NetLogCaptureMode {
// no effort to strip cookies and credentials.
// include_cookies_and_credentials() --> true
// include_socket_bytes() --> false
+ // TODO(bnc): Consider renaming to IncludePrivacyInfo().
static NetLogCaptureMode IncludeCookiesAndCredentials();
// Constructs a capture mode which logs the data sent/received from sockets.
@@ -41,6 +42,7 @@ class NET_EXPORT NetLogCaptureMode {
// If include_cookies_and_credentials() is true , then it is OK to log
// events which contain cookies, credentials or other privacy sensitive data.
+ // TODO(bnc): Consider renaming to include_privacy_info().
bool include_cookies_and_credentials() const;
// If include_socket_bytes() is true, then it is OK to output the actual
« no previous file with comments | « net/http/http_log_util_unittest.cc ('k') | net/log/net_log_capture_mode.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698