Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: net/log/net_log_capture_mode.h

Issue 1360253002: Log GOAWAY frame debug data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re: #7. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/log/net_log_capture_mode.h
diff --git a/net/log/net_log_capture_mode.h b/net/log/net_log_capture_mode.h
index e08e2ad436ae84474a70d0fb7edd69cd9cc240ca..eb6ce10519c594529fd65ea56f1efe269ed012cb 100644
--- a/net/log/net_log_capture_mode.h
+++ b/net/log/net_log_capture_mode.h
@@ -32,6 +32,8 @@ class NET_EXPORT NetLogCaptureMode {
// no effort to strip cookies and credentials.
// include_cookies_and_credentials() --> true
// include_socket_bytes() --> false
+ // TODO(bnc): Consider renaming to
+ // IncludeCookiesAndCredentialsAndGoAwayDebugData().
eroman 2015/10/07 17:00:51 IncludePrivacyInfo ? (not the best name, but "Pri
Bence 2015/10/30 11:55:26 Done.
static NetLogCaptureMode IncludeCookiesAndCredentials();
// Constructs a capture mode which logs the data sent/received from sockets.
@@ -41,6 +43,8 @@ class NET_EXPORT NetLogCaptureMode {
// If include_cookies_and_credentials() is true , then it is OK to log
// events which contain cookies, credentials or other privacy sensitive data.
+ // TODO(bnc): Consider renaming to
+ // include_cookies_and_credentials_and_goaway_debug_data().
bool include_cookies_and_credentials() const;
// If include_socket_bytes() is true, then it is OK to output the actual

Powered by Google App Engine
This is Rietveld 408576698