Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: net/spdy/buffered_spdy_framer.h

Issue 1360253002: Log GOAWAY frame debug data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Initialize |goaway_count_|. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/buffered_spdy_framer.h
diff --git a/net/spdy/buffered_spdy_framer.h b/net/spdy/buffered_spdy_framer.h
index ee73f0893cb166fea7d2ad7aabe20bec0e1c99b3..c23f7d553651042e66fba566fa77f10a17e68f21 100644
--- a/net/spdy/buffered_spdy_framer.h
+++ b/net/spdy/buffered_spdy_framer.h
@@ -100,7 +100,8 @@ class NET_EXPORT_PRIVATE BufferedSpdyFramerVisitorInterface {
// Called when a GOAWAY frame has been parsed.
virtual void OnGoAway(SpdyStreamId last_accepted_stream_id,
- SpdyGoAwayStatus status) = 0;
+ SpdyGoAwayStatus status,
+ base::StringPiece debug_data) = 0;
// Called when a WINDOW_UPDATE frame has been parsed.
virtual void OnWindowUpdate(SpdyStreamId stream_id,
@@ -173,6 +174,7 @@ class NET_EXPORT_PRIVATE BufferedSpdyFramer
void OnRstStream(SpdyStreamId stream_id, SpdyRstStreamStatus status) override;
void OnGoAway(SpdyStreamId last_accepted_stream_id,
SpdyGoAwayStatus status) override;
+ bool OnGoAwayFrameData(const char* goaway_data, size_t len) override;
void OnWindowUpdate(SpdyStreamId stream_id, int delta_window_size) override;
void OnPushPromise(SpdyStreamId stream_id,
SpdyStreamId promised_stream_id,
@@ -203,9 +205,9 @@ class NET_EXPORT_PRIVATE BufferedSpdyFramer
SpdyRstStreamStatus status) const;
SpdyFrame* CreateSettings(const SettingsMap& values) const;
SpdyFrame* CreatePingFrame(SpdyPingId unique_id, bool is_ack) const;
- SpdyFrame* CreateGoAway(
- SpdyStreamId last_accepted_stream_id,
- SpdyGoAwayStatus status) const;
+ SpdyFrame* CreateGoAway(SpdyStreamId last_accepted_stream_id,
+ SpdyGoAwayStatus status,
+ base::StringPiece debug_data) const;
SpdyFrame* CreateHeaders(SpdyStreamId stream_id,
SpdyControlFlags flags,
SpdyPriority priority,
@@ -287,6 +289,14 @@ class NET_EXPORT_PRIVATE BufferedSpdyFramer
};
scoped_ptr<ControlFrameFields> control_frame_fields_;
+ // Collection of fields of a GOAWAY frame that we need to buffer.
eroman 2015/10/06 17:19:41 nit: I see other comments similarly use "we", howe
Bence 2015/10/07 15:18:27 Done.
+ struct GoAwayFields {
+ SpdyStreamId last_accepted_stream_id;
+ SpdyGoAwayStatus status;
+ std::string debug_data;
+ };
+ scoped_ptr<GoAwayFields> go_away_fields_;
+
DISALLOW_COPY_AND_ASSIGN(BufferedSpdyFramer);
};

Powered by Google App Engine
This is Rietveld 408576698