net/spdy/buffered_spdy_framer_unittest.cc - Issue 1360253002: Log GOAWAY frame debug data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/buffered_spdy_framer_unittest.cc

Issue 1360253002: Log GOAWAY frame debug data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nit. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/buffered_spdy_framer_unittest.cc

diff --git a/net/spdy/buffered_spdy_framer_unittest.cc b/net/spdy/buffered_spdy_framer_unittest.cc

index 5f05fa1d2085180e5a9424625fd118da30193e2f..eb0ff206cc37ce8539aab129f6e1b35e59667bce 100644

--- a/net/spdy/buffered_spdy_framer_unittest.cc

+++ b/net/spdy/buffered_spdy_framer_unittest.cc

@@ -100,7 +100,8 @@ class TestBufferedSpdyVisitor : public BufferedSpdyFramerVisitorInterface {

SpdyRstStreamStatus status) override {}

void OnGoAway(SpdyStreamId last_accepted_stream_id,

- SpdyGoAwayStatus status) override {}

+ SpdyGoAwayStatus status,

+ StringPiece debug_data) override {}

Ryan Hamilton 2015/10/05 21:17:55 Since we're now buffering GOAWAY data, can you add

Bence 2015/10/06 15:18:57 Done.

bool OnCredentialFrameData(const char*, size_t) {

LOG(FATAL) << "Unexpected OnCredentialFrameData call.";