Log GOAWAY frame debug data.

chrome/browser/resources/net_internals/log_view_painter.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(eroman): put these methods into a namespace.
 
 var createLogEntryTablePrinter;
 var proxySettingsToString;
-var stripCookiesAndLoginInfo;
+var stripCookiesAndLoginInfoAndGoAwayDebugData;
 
 // Start of anonymous namespace.
 (function() {
 'use strict';
 
 function canCollapseBeginWithEnd(beginEntry) {
   return beginEntry &&
          beginEntry.isBegin() &&
          beginEntry.end &&
          beginEntry.end.index == beginEntry.index + 1 &&
@@ skipping 217 matching lines @@
 })();  // end of ParameterOutputter
 
 /**
  * Formats the parameters for |entry| and writes them to |out|.
  * Certain event types have custom pretty printers. Everything else will
  * default to a JSON-like format.
  */
 function writeParameters(entry, privacyStripping, out) {
   if (privacyStripping) {
     // If privacy stripping is enabled, remove data as needed.
-    entry = stripCookiesAndLoginInfo(entry);
+    entry = stripCookiesAndLoginInfoAndGoAwayDebugData(entry);
   } else {
     // If headers are in an object, convert them to an array for better display.
     entry = reformatHeaders(entry);
   }
 
   // Use any parameter writer available for this event type.
   var paramsWriter = getParamaterWriterForEventType(entry.type);
   var consumedParams = {};
   if (paramsWriter)
     paramsWriter(entry, out, consumedParams);
@@ skipping 214 matching lines @@
     headers.push(key + ': ' + entry.params.headers[key]);
   entry.params.headers = headers;
 
   return entry;
 }
 
 /**
  * Removes a cookie or unencrypted login information from a single HTTP header
  * line, if present, and returns the modified line.  Otherwise, just returns
  * the original line.
+ *
+ * Note: this logic should be kept in sync with
+ * net::ElideHeaderValueForNetLog in net/http/http_log_util.cc.
  */
 function stripCookieOrLoginInfo(line) {
   var patterns = [
       // Cookie patterns
       /^set-cookie: /i,
       /^set-cookie2: /i,
       /^cookie: /i,
 
       // Unencrypted authentication patterns
       /^authorization: \S*\s*/i,
@@ skipping 46 matching lines @@
     // This is often the case when viewing a loaded log.
     if (suffix.search(/^\[[0-9]+ bytes were stripped\]$/) == -1) {
       return prefix + '[' + suffix.length + ' bytes were stripped]';
     }
   }
 
   return line;
 }
 
 /**
+ * Remove debug data from HTTP/2 GOAWAY frame due to privacy considerations, see
+ * https://httpwg.github.io/specs/rfc7540.html#GOAWAY.
+ *
+ * Note: this logic should be kept in sync with
+ * net::ElideGoAwayDebugDataForNetLog in net/http/http_log_util.cc.
+ */
+function stripGoAwayDebugData(value) {
+  return '[' + value.length + ' bytes were stripped]';
+}
+
+/**
  * If |entry| has headers, returns a copy of |entry| with all cookie and
  * unencrypted login text removed.  Otherwise, returns original |entry| object.
  * This is needed so that JSON log dumps can be made without affecting the
  * source data.  Converts headers stored in objects to arrays.
- *
- * Note: this logic should be kept in sync with
- * net::ElideHeaderForNetLog in net/http/http_log_util.cc.
  */
-stripCookiesAndLoginInfo = function(entry) {
-  if (!entry.params || entry.params.headers === undefined ||
+stripCookiesAndLoginInfoAndGoAwayDebugData = function(entry) {

[eroman, 2015/10/07 17:00:51]

This name is accurate however a bit too long IMO.

What about "stripPrivacyInfo()" ? (I imagine we will keep adding things to this,
so the more general name my age better). This also seems in line with the
"privacyStripping" variable that it is conditionally called on.

[Bence, 2015/10/30 11:55:26]

stripPrivacyInfo sounds a lot better, should have thought about that.

Done.

+  if (!entry.params) {
+    return entry;
+  }
+
+  if (entry.type == EventType.HTTP2_SESSION_GOAWAY &&
+      entry.params.debug_data != undefined) {
+    // Duplicate the top level object, and |entry.params|.  All other fields are
+    // just pointers to the original values, as they won't be modified, other
+    // than |entry.params.debug_data|.
+    entry = shallowCloneObject(entry);
+    entry.params = shallowCloneObject(entry.params);
+    entry.params.debug_data =
+        stripGoAwayDebugData(entry.params.debug_data);
+    return entry;
+  }
+
+  if (entry.params.headers === undefined ||
       !(entry.params.headers instanceof Object)) {
     return entry;
   }
 
   // Make sure entry's headers are in an array.
   entry = reformatHeaders(entry);
 
   // Duplicate the top level object, and |entry.params|.  All other fields are
   // just pointers to the original values, as they won't be modified, other than
   // |entry.params.headers|.
@@ skipping 207 matching lines @@
   }
 
   if (config.source != undefined && config.source != 'UNKNOWN')
     result.push('Source: ' + config.source);
 
   return result.join('\n');
 };
 
 // End of anonymous namespace.
 })();