bindings: Moves event handlers and methods of Window to the instance object.

third_party/WebKit/Source/bindings/templates/interface.cpp

Index: third_party/WebKit/Source/bindings/templates/interface.cpp
diff --git a/third_party/WebKit/Source/bindings/templates/interface.cpp b/third_party/WebKit/Source/bindings/templates/interface.cpp
index 33be1e4b5eec5643d2e72dc1c0914855de23159e..ca3384212f2425b4429a64c8464301ddd46e7434 100644
--- a/third_party/WebKit/Source/bindings/templates/interface.cpp
+++ b/third_party/WebKit/Source/bindings/templates/interface.cpp
@@ -635,7 +635,7 @@ void {{v8_class}}::constructorCallback(const v8::FunctionCallbackInfo<v8::Value>
 {% endif %}
 {% set property_attribute =
        'static_cast<v8::PropertyAttribute>(%s)' %
-       ' | '.join(method.property_attributes or ['v8::DontDelete']) %}
+       ' | '.join(method.property_attributes or ['v8::None']) %}

[haraken, 2015/09/25 10:41:35]

Just help me understand: Why do we need to make this change?

[Yuki, 2015/09/25 14:40:43]

Unless it's [Unforgeable], JS properties corresponding to attributes or
operations should be {configuable: true}.  This is true even for whitelisted
members of Window.

Especially when we're moving them to the instance object, if it's
v8::DontDelete, the following code doesn't work.
    // in the global scope
    function toString() { ... }
because we already have toString() method on the instance object of Window.

 {% set only_exposed_to_private_script = 'V8DOMConfiguration::OnlyExposedToPrivateScript' if method.only_exposed_to_private_script else 'V8DOMConfiguration::ExposedToAllScripts' %}
 {% set holder_check = 'V8DOMConfiguration::DoNotCheckHolder' if method.is_do_not_check_signature else 'V8DOMConfiguration::CheckHolder' %}
 const V8DOMConfiguration::AttributeConfiguration {{method.name}}OriginSafeAttributeConfiguration = {