Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1360233005: Set the browser window bounds to fit to the Xvfb's size (Closed)

Created:
5 years, 3 months ago by oshima
Modified:
5 years, 2 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, use rdevlin.cronin at chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the browser window bounds to fit to the Xvfb's size. Chrome for ChromeOS currently places the window at 200x200 with 1366x768 size by default. This puts the parts of UI outside of Xvfb window, where the mouse cursor cannot be moved into. Default size is 1280x1024 and I'm using the 1280x800 that is one of resolution actually used on the device. BUG=None Committed: https://crrev.com/a079bd3874ca35ff457e313f389b9075a87fd073 Cr-Commit-Position: refs/heads/master@{#351080}

Patch Set 1 : #

Patch Set 2 : don't set if already set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/test/base/in_process_browser_test.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360233005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360233005/20001
5 years, 3 months ago (2015-09-24 17:59:32 UTC) #4
oshima
5 years, 3 months ago (2015-09-24 18:03:05 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/107421)
5 years, 3 months ago (2015-09-24 18:45:00 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360233005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360233005/40001
5 years, 3 months ago (2015-09-24 19:56:51 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-24 20:43:16 UTC) #11
Paweł Hajdan Jr.
Is there a reason to put it here as opposed to src/content/public/test/browser_test_base.cc ?
5 years, 2 months ago (2015-09-25 10:46:50 UTC) #12
oshima
On 2015/09/25 10:46:50, Paweł Hajdan Jr. wrote: > Is there a reason to put it ...
5 years, 2 months ago (2015-09-26 01:31:53 UTC) #13
Paweł Hajdan Jr.
LGTM
5 years, 2 months ago (2015-09-28 09:44:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360233005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360233005/40001
5 years, 2 months ago (2015-09-28 15:41:47 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 2 months ago (2015-09-28 16:14:01 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 16:15:19 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a079bd3874ca35ff457e313f389b9075a87fd073
Cr-Commit-Position: refs/heads/master@{#351080}

Powered by Google App Engine
This is Rietveld 408576698