Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1360223002: Remove some redundant frame parameters from WebFrameClient. (Closed)

Created:
5 years, 3 months ago by Avi (use Gerrit)
Modified:
5 years, 3 months ago
Reviewers:
Nate Chapin, dmazzoni
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some redundant frame parameters from WebFrameClient. BUG=361765 TEST=no changes Committed: https://crrev.com/dc4213403af73b0d2fb05cc9c0420f72209a8a9f Cr-Commit-Position: refs/heads/master@{#350378}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -21 lines) Patch
M components/test_runner/web_frame_test_proxy.h View 1 chunk +3 lines, -4 lines 0 comments Download
M components/test_runner/web_test_proxy.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/test_runner/web_test_proxy.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360223002/1
5 years, 3 months ago (2015-09-23 18:08:45 UTC) #2
Avi (use Gerrit)
japhet@chromium.org: Please review changes in Blink dmazzoni@chromium.org: Please review changes in Chromium components/ :)
5 years, 3 months ago (2015-09-23 18:27:03 UTC) #4
dmazzoni
lgtm for components/test_runner
5 years, 3 months ago (2015-09-23 18:32:29 UTC) #5
Nate Chapin
webkit lgtm
5 years, 3 months ago (2015-09-23 18:36:27 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/117320)
5 years, 3 months ago (2015-09-23 19:07:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360223002/1
5 years, 3 months ago (2015-09-23 19:17:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/106788)
5 years, 3 months ago (2015-09-23 19:57:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360223002/1
5 years, 3 months ago (2015-09-23 20:00:18 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/56617) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 3 months ago (2015-09-23 20:39:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360223002/1
5 years, 3 months ago (2015-09-23 21:06:23 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-23 22:54:57 UTC) #19
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 22:56:12 UTC) #20
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dc4213403af73b0d2fb05cc9c0420f72209a8a9f
Cr-Commit-Position: refs/heads/master@{#350378}

Powered by Google App Engine
This is Rietveld 408576698