Fix media element time display for times over an hour.

Fix media element time display for times over an hour.

Moves a misplaced modulo so that hours can become nonzero when constructing the time and duration strings for HTMLMediaElement.

Also added a test for it.

BUG=535046

[liberato (no reviews please), 2015-09-23 15:52:59]

liberato@chromium.org changed reviewers:
+ dalecurtis@chromium.org, philipj@opera.com

[liberato (no reviews please), 2015-09-23 15:53:24]

haven't tried on a device yet (wfh) but the new test went from failing to
passing.

https://codereview.chromium.org/1360203002/diff/1/Source/core/testing/Interna...
File Source/core/testing/InternalSettings.idl (right):

https://codereview.chromium.org/1360203002/diff/1/Source/core/testing/Interna...
Source/core/testing/InternalSettings.idl:68: void
setNewMediaPlaybackUiEnabled(boolean enabled);
i didn't see a way to make a setter out of this in RuntimeFlags as suggested in
the comment, so i just added it here.  it didn't look like there was a mechanism
for generating setters there.

[DaleCurtis, 2015-09-23 16:15:07]

blink merge is still in progress, so I think you'll need to manually redo this
CL later after that completes (it currently points at the wrong base url).

[liberato (no reviews please), 2015-09-24 06:00:48]

moved over to tolkien*-repo.

-fl

* one repo to hold the code.
one repo to sync them.
one repo to land CLs.
and to a callback bind them.

[DaleCurtis, 2015-09-24 17:05:52]

Love your commit comments :) LayoutTheme.cpp lgtm of course, but defer to
philipj@ for test process.

[philipj_slow, 2015-09-25 07:45:21]

The fix LGTM, but the test is basically a unit test, so if it could be written
as LayoutThemeTest.cpp that ought to be less code and run faster too.

[liberato (no reviews please), 2015-09-25 16:03:56]

it's now a two file CL.  thanks, philipj!

-fl

[DaleCurtis, 2015-09-25 16:49:25]

https://codereview.chromium.org/1360203002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutThemeTest.cpp (right):

https://codereview.chromium.org/1360203002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutThemeTest.cpp:132: for (unsigned i =
0; i < sizeof(tests) / sizeof(tests[0]); i++)  {
for (const auto& expectation : tests) ?

[liberato (no reviews please), 2015-09-25 16:53:31]

On 2015/09/25 16:49:25, DaleCurtis wrote:
>
https://codereview.chromium.org/1360203002/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/layout/LayoutThemeTest.cpp (right):
> 
>
https://codereview.chromium.org/1360203002/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/layout/LayoutThemeTest.cpp:132: for (unsigned i
=
> 0; i < sizeof(tests) / sizeof(tests[0]); i++)  {
> for (const auto& expectation : tests) ?

thanks.

also, i moved this over to https://codereview.chromium.org/1369763002/
post-merge.

-fl