drive: Add a very basic browser test for Drive in Files.app

drive: Add a very basic browser test for Drive in Files.app

Here is first cut at adding the long-awaited browser tests for Drive in
Files.app. In this patch, only "TestFileDisplay" is ported to Drive.
Other tests will be ported in separate patches.

BUG=224534
TEST=none; just added a test.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193016

[satorux1, 2013-04-04 05:58:31]

Finally!

[kinaba, 2013-04-04 06:33:17]

Congrats!

https://codereview.chromium.org/13602004/diff/2001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_manager_browsertest.cc (right):

https://codereview.chromium.org/13602004/diff/2001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager_browsertest.cc:90: int length,
int64 instead of int is used for file size everywhere so perhaps it is better to
follow.

https://codereview.chromium.org/13602004/diff/2001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager_browsertest.cc:257:
ASSERT_TRUE(test_cache_root_.CreateUniqueTempDirUnderPath(tmp_dir_path));
test_cache_root_.CreateUniqueTempDir()
should create a directory under DIR_TEMP.

[satorux1, 2013-04-05 02:24:04]

https://codereview.chromium.org/13602004/diff/2001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_manager_browsertest.cc (right):

https://codereview.chromium.org/13602004/diff/2001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager_browsertest.cc:90: int length,
On 2013/04/04 06:33:17, kinaba wrote:
> int64 instead of int is used for file size everywhere so perhaps it is better
to
> follow.

Done.

https://codereview.chromium.org/13602004/diff/2001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager_browsertest.cc:257:
ASSERT_TRUE(test_cache_root_.CreateUniqueTempDirUnderPath(tmp_dir_path));
On 2013/04/04 06:33:17, kinaba wrote:
> test_cache_root_.CreateUniqueTempDir()
> should create a directory under DIR_TEMP.

Done. thanks!

[kinaba, 2013-04-05 02:28:21]

lgtm

[satorux1, 2013-04-05 07:26:29]

Turned out the new test was very flaky on Release build. 

Here's what I learned so far:

In getFileList(), we should be able to get the list of files, but the list is
empty when the test fails. Setting some delay makes the test mode likely to
pass, but not the right solution.

In file_manager_browsertest.cc, we wait until the page is loaded using the
signal, but this looks wrong:

  ExtensionTestMessageListener listener("worker-initialized", false);

[satorux1, 2013-04-05 07:36:30]

On 2013/04/05 07:26:29, satorux1 wrote:
> Turned out the new test was very flaky on Release build. 
> 
> Here's what I learned so far:
> 
> In getFileList(), we should be able to get the list of files, but the list is
> empty when the test fails. Setting some delay makes the test mode likely to
> pass, but not the right solution.
> 
> In file_manager_browsertest.cc, we wait until the page is loaded using the
> signal, but this looks wrong:
> 
>   ExtensionTestMessageListener listener("worker-initialized", false);

Well, the C++ code may be ok. Found a way to make the test robust in JavaScript.
Will create a separate patch.

[satorux1, 2013-04-05 07:45:50]

The JS change: https://codereview.chromium.org/13450004/

[satorux1, 2013-04-08 00:51:53]

The test is now failing with another reason...

With crrev.com/192554, navigating to chrome-extension://...main.html#%2Fdrive
(Drive) no longer works. Somehow, the page is redirected to #%2fDownloads (local
Downloads)...

[satorux1, 2013-04-08 01:07:48]

Changed the landing URL to %2Fdrive%2Froot, but still failing...

[satorux1, 2013-04-08 01:29:26]

On 2013/04/08 01:07:48, satorux1 wrote:
> Changed the landing URL to %2Fdrive%2Froot, but still failing...

This is complicated. DirectoryModel.resolveDirectory is broken. Here's the code.

  if (PathUtil.getRootType(path) == RootType.DRIVE) {
    if (!this.isDriveMounted()) {
      if (path == DirectoryModel.fakeDriveEntry_.fullPath)
        successCallback(DirectoryModel.fakeDriveEntry_);
      else  // Subdirectory.                                                    
 
        errorCallback({ code: FileError.NOT_FOUND_ERR });
      return;
    }
  }

Previously, "if (path == DirectoryModel.fakeDriveEntry_.fullPath)" was true, but
this is no longer true, due to this change
https://chromiumcodereview.appspot.com/13149003/diff/21002/chrome/browser/res...

[satorux1, 2013-04-08 05:36:02]

The JS failure will be fixed in another patch, which should be submitted before
this.

Meanwhile, just fixed the path in browsertests.cc

[satorux1, 2013-04-08 06:15:09]

Filed a bug for the JS fix: crbug.com/227488

[satorux1, 2013-04-09 05:22:09]

Committed patchset #8 manually as r193016 (presubmit successful).