Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1360143003: [DevTools] Do not use AboutToNavigateRenderFrame in DevToolsUIBindings. (Closed)

Created:
5 years, 2 months ago by dgozman
Modified:
5 years, 2 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not use AboutToNavigateRenderFrame in DevToolsUIBindings. DidStartProvisionalLoadForFrame is enough here. BUG=none Committed: https://crrev.com/ee6eca69ffbd1d510d02397df5047f27cc256e8e Cr-Commit-Position: refs/heads/master@{#350974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M chrome/browser/devtools/devtools_ui_bindings.cc View 2 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dgozman
Take a look please.
5 years, 2 months ago (2015-09-25 21:34:15 UTC) #2
pfeldman
lgtm
5 years, 2 months ago (2015-09-25 21:44:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360143003/1
5 years, 2 months ago (2015-09-25 21:45:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/118503)
5 years, 2 months ago (2015-09-25 23:11:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360143003/1
5 years, 2 months ago (2015-09-26 01:26:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-26 02:39:21 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ee6eca69ffbd1d510d02397df5047f27cc256e8e Cr-Commit-Position: refs/heads/master@{#350974}
5 years, 2 months ago (2015-09-26 02:40:15 UTC) #11
dgozman
5 years, 2 months ago (2015-09-28 20:54:47 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1369413002/ by dgozman@chromium.org.

The reason for reverting is: This patch added a race. It should be using
DidStartNavigationToPendingEntry instead..

Powered by Google App Engine
This is Rietveld 408576698