Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1360133002: [test] Add FOR_INT64_INPUTS and FOR_UINT64_INPUTS. (Closed)

Created:
5 years, 3 months ago by titzer
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Add FOR_INT64_INPUTS and FOR_UINT64_INPUTS. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/654bcec06f0b9354f46549c843e80f442693e0fd Cr-Commit-Position: refs/heads/master@{#30884}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -4 lines) Patch
M test/cctest/compiler/test-run-machops.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M test/cctest/compiler/value-helper.h View 1 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
titzer
5 years, 3 months ago (2015-09-23 10:36:01 UTC) #1
Benedikt Meurer
We can use C++11 now, please just use C++11 for(x:v) loop.
5 years, 3 months ago (2015-09-23 10:37:01 UTC) #2
titzer
On 2015/09/23 10:37:01, Benedikt Meurer wrote: > We can use C++11 now, please just use ...
5 years, 3 months ago (2015-09-23 10:38:23 UTC) #3
Benedikt Meurer
Ok, please do. LGTM
5 years, 3 months ago (2015-09-23 10:38:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360133002/20001
5 years, 3 months ago (2015-09-23 10:40:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-23 11:04:48 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:05:06 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/654bcec06f0b9354f46549c843e80f442693e0fd
Cr-Commit-Position: refs/heads/master@{#30884}

Powered by Google App Engine
This is Rietveld 408576698