Introduce RenderFrame::IsMainFrame and clean up a few things.

Introduce RenderFrame::IsMainFrame and clean up a few things.

To determine if RenderFrame represents a main frame (top of the
frame tree), there's a typical check done today in code:

render_frame->GetWebFrame()->parent()

To make this check more easily understood, we add the titular
function. In addition:

* Reversed existing RenderFrameImpl::is_subframe to align with
  the newly added function.

* Removed obsolete comment in ContentRendererClient.

* Tweaked ChromeContentRendererClient to use the new function.

BUG=
R=creis@chromium.org

Committed: https://crrev.com/2e140f5801f4d426b5e0339d612b997e0657bff0
Cr-Commit-Position: refs/heads/master@{#351077}

[dglazkov, 2015-09-25 21:55:13]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-25 21:56:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1360123006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1360123006/1

[commit-bot: I haz the power, 2015-09-25 22:11:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-25 22:11:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dglazkov, 2015-09-25 22:17:36]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-25 22:18:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1360123006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1360123006/20001

[dglazkov, 2015-09-25 22:49:01]

PTAL.

[Charlie Reis, 2015-09-26 00:08:04]

Much nicer, thanks!  LGTM.

https://codereview.chromium.org/1360123006/diff/20001/chrome/renderer/chrome_...
File chrome/renderer/chrome_content_renderer_client.cc (left):

https://codereview.chromium.org/1360123006/diff/20001/chrome/renderer/chrome_...
chrome/renderer/chrome_content_renderer_client.cc:570: if
(render_frame->GetWebFrame()->parent() == nullptr) {
Wow, that was pretty silly.  Guess each of these 3 blocks was added by someone
different.

https://codereview.chromium.org/1360123006/diff/20001/content/public/renderer...
File content/public/renderer/render_frame.h (right):

https://codereview.chromium.org/1360123006/diff/20001/content/public/renderer...
content/public/renderer/render_frame.h:119: // (That's the frame at the top of
the frame tree).
nit: No need for the clarification, I think.  At most, "the main (top-level)
frame" would be sufficient.

https://codereview.chromium.org/1360123006/diff/20001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/1360123006/diff/20001/content/renderer/render...
content/renderer/render_frame_impl.cc:683: is_main_frame_(false),
Maybe this should default to true, to match the previous (pre-Initialize)
behavior.

[commit-bot: I haz the power, 2015-09-26 00:12:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-26 00:12:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dglazkov, 2015-09-26 00:24:34]

On 2015/09/26 at 00:12:51, commit-bot wrote:
> Dry run: Try jobs failed on following builders:
>   linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Thank you, ASAN. I just realized how awesome the OnSwap function is.

[dglazkov, 2015-09-28 04:02:17]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-28 04:02:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1360123006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1360123006/40001

[dglazkov, 2015-09-28 04:03:35]

https://codereview.chromium.org/1360123006/diff/20001/content/public/renderer...
File content/public/renderer/render_frame.h (right):

https://codereview.chromium.org/1360123006/diff/20001/content/public/renderer...
content/public/renderer/render_frame.h:119: // (That's the frame at the top of
the frame tree).
On 2015/09/26 at 00:08:04, Charlie Reis wrote:
> nit: No need for the clarification, I think.  At most, "the main (top-level)
frame" would be sufficient.

Done.

https://codereview.chromium.org/1360123006/diff/20001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/1360123006/diff/20001/content/renderer/render...
content/renderer/render_frame_impl.cc:683: is_main_frame_(false),
On 2015/09/26 at 00:08:04, Charlie Reis wrote:
> Maybe this should default to true, to match the previous (pre-Initialize)
behavior.

Done.

[commit-bot: I haz the power, 2015-09-28 07:24:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 07:24:05]

Dry run: This issue passed the CQ dry run.

[dglazkov, 2015-09-28 14:45:58]

The CQ bit was checked by dglazkov@chromium.org

[dglazkov, 2015-09-28 14:45:58]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/1360123006/#ps40001
(title: "Fixed use-after-free.")

[commit-bot: I haz the power, 2015-09-28 14:46:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1360123006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1360123006/40001

[commit-bot: I haz the power, 2015-09-28 14:54:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 14:54:34]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jam, 2015-09-28 16:02:12]

jam@chromium.org changed reviewers:
+ jam@chromium.org

[jam, 2015-09-28 16:02:13]

lgtm

[dglazkov, 2015-09-28 16:02:57]

The CQ bit was checked by dglazkov@chromium.org

[commit-bot: I haz the power, 2015-09-28 16:04:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1360123006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1360123006/40001

[commit-bot: I haz the power, 2015-09-28 16:10:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-28 16:11:20]

Patchset 3 (id:??) landed as
https://crrev.com/2e140f5801f4d426b5e0339d612b997e0657bff0
Cr-Commit-Position: refs/heads/master@{#351077}