Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Side by Side Diff: components/test_runner/test_plugin.h

Issue 1360123005: Enforce marking "override" for functions overriding Blink in components/test_runner/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_TEST_RUNNER_TEST_PLUGIN_H_ 5 #ifndef COMPONENTS_TEST_RUNNER_TEST_PLUGIN_H_
6 #define COMPONENTS_TEST_RUNNER_TEST_PLUGIN_H_ 6 #define COMPONENTS_TEST_RUNNER_TEST_PLUGIN_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 const blink::WebPluginParams& params, 51 const blink::WebPluginParams& params,
52 WebTestDelegate* delegate); 52 WebTestDelegate* delegate);
53 ~TestPlugin() override; 53 ~TestPlugin() override;
54 54
55 static const blink::WebString& MimeType(); 55 static const blink::WebString& MimeType();
56 static const blink::WebString& CanCreateWithoutRendererMimeType(); 56 static const blink::WebString& CanCreateWithoutRendererMimeType();
57 static const blink::WebString& PluginPersistsMimeType(); 57 static const blink::WebString& PluginPersistsMimeType();
58 static bool IsSupportedMimeType(const blink::WebString& mime_type); 58 static bool IsSupportedMimeType(const blink::WebString& mime_type);
59 59
60 // WebPlugin methods: 60 // WebPlugin methods:
61 virtual bool initialize(blink::WebPluginContainer* container); 61 bool initialize(blink::WebPluginContainer* container) override;
62 virtual void destroy(); 62 void destroy() override;
63 virtual NPObject* scriptableObject(); 63 NPObject* scriptableObject() override;
64 virtual bool canProcessDrag() const; 64 bool canProcessDrag() const override;
65 virtual bool supportsKeyboardFocus() const; 65 bool supportsKeyboardFocus() const override;
66 virtual void layoutIfNeeded() override { } 66 void layoutIfNeeded() override {}
67 virtual void paint(blink::WebCanvas* canvas, const blink::WebRect& rect) {} 67 void paint(blink::WebCanvas* canvas, const blink::WebRect& rect) override {}
68 virtual void updateGeometry( 68 void updateGeometry(const blink::WebRect& window_rect,
69 const blink::WebRect& window_rect, 69 const blink::WebRect& clip_rect,
70 const blink::WebRect& clip_rect, 70 const blink::WebRect& unobscured_rect,
71 const blink::WebRect& unobscured_rect, 71 const blink::WebVector<blink::WebRect>& cut_outs_rects,
72 const blink::WebVector<blink::WebRect>& cut_outs_rects, 72 bool is_visible) override;
73 bool is_visible); 73 void updateFocus(bool focus, blink::WebFocusType focus_type) override {}
74 virtual void updateFocus(bool focus, blink::WebFocusType focus_type) {} 74 void updateVisibility(bool visibility) override {}
75 virtual void updateVisibility(bool visibility) {} 75 bool acceptsInputEvents() override;
76 virtual bool acceptsInputEvents(); 76 bool handleInputEvent(const blink::WebInputEvent& event,
77 virtual bool handleInputEvent(const blink::WebInputEvent& event, 77 blink::WebCursorInfo& info) override;
78 blink::WebCursorInfo& info); 78 bool handleDragStatusUpdate(blink::WebDragStatus drag_status,
79 virtual bool handleDragStatusUpdate(blink::WebDragStatus drag_status, 79 const blink::WebDragData& data,
80 const blink::WebDragData& data, 80 blink::WebDragOperationsMask mask,
81 blink::WebDragOperationsMask mask, 81 const blink::WebPoint& position,
82 const blink::WebPoint& position, 82 const blink::WebPoint& screen_position) override;
83 const blink::WebPoint& screen_position); 83 void didReceiveResponse(const blink::WebURLResponse& response) override {}
84 virtual void didReceiveResponse(const blink::WebURLResponse& response) {} 84 void didReceiveData(const char* data, int data_length) override {}
85 virtual void didReceiveData(const char* data, int data_length) {} 85 void didFinishLoading() override {}
86 virtual void didFinishLoading() {} 86 void didFailLoading(const blink::WebURLError& error) override {}
87 virtual void didFailLoading(const blink::WebURLError& error) {} 87 void didFinishLoadingFrameRequest(const blink::WebURL& url,
88 virtual void didFinishLoadingFrameRequest(const blink::WebURL& url, 88 void* notify_data) override {}
89 void* notify_data) {} 89 void didFailLoadingFrameRequest(const blink::WebURL& url,
90 virtual void didFailLoadingFrameRequest(const blink::WebURL& url, 90 void* notify_data,
91 void* notify_data, 91 const blink::WebURLError& error) override {}
92 const blink::WebURLError& error) {} 92 bool isPlaceholder() override;
93 virtual bool isPlaceholder();
94 93
95 // cc::TextureLayerClient methods: 94 // cc::TextureLayerClient methods:
96 bool PrepareTextureMailbox( 95 bool PrepareTextureMailbox(
97 cc::TextureMailbox* mailbox, 96 cc::TextureMailbox* mailbox,
98 scoped_ptr<cc::SingleReleaseCallback>* release_callback, 97 scoped_ptr<cc::SingleReleaseCallback>* release_callback,
99 bool use_shared_memory) override; 98 bool use_shared_memory) override;
100 99
101 private: 100 private:
102 TestPlugin(blink::WebFrame* frame, 101 TestPlugin(blink::WebFrame* frame,
103 const blink::WebPluginParams& params, 102 const blink::WebPluginParams& params,
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 174
176 bool is_persistent_; 175 bool is_persistent_;
177 bool can_create_without_renderer_; 176 bool can_create_without_renderer_;
178 177
179 DISALLOW_COPY_AND_ASSIGN(TestPlugin); 178 DISALLOW_COPY_AND_ASSIGN(TestPlugin);
180 }; 179 };
181 180
182 } // namespace test_runner 181 } // namespace test_runner
183 182
184 #endif // COMPONENTS_TEST_RUNNER_TEST_PLUGIN_H_ 183 #endif // COMPONENTS_TEST_RUNNER_TEST_PLUGIN_H_
OLDNEW
« no previous file with comments | « components/test_runner/spell_check_client.h ('k') | components/test_runner/web_content_settings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698