core/include/fpdfapi/fpdf_parser.h - Issue 1360103002: Get rid of gotos in CPDF_SyntaxParser and FlateUncompress().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fpdfapi/fpdf_parser.h

Issue 1360103002: Get rid of gotos in CPDF_SyntaxParser and FlateUncompress(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: address comments, more cleanups Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/include/fpdfapi/fpdf_parser.h

diff --git a/core/include/fpdfapi/fpdf_parser.h b/core/include/fpdfapi/fpdf_parser.h

index 03ae4cf5706117a6647f14adb1db7b9e84b3aa3b..abfe8bf277c57292d492fe8e5b5e93501ea75292 100644

--- a/core/include/fpdfapi/fpdf_parser.h

+++ b/core/include/fpdfapi/fpdf_parser.h

@@ -452,10 +452,10 @@ class CPDF_Parser {

FX_BOOL LoadAllCrossRefV5(FX_FILESIZE pos);

- FX_BOOL LoadCrossRefV4(FX_FILESIZE pos,

- FX_FILESIZE streampos,

- FX_BOOL bSkip,

- FX_BOOL bFirst);

+ bool LoadCrossRefV4(FX_FILESIZE pos,

+ FX_FILESIZE streampos,

+ FX_BOOL bSkip,

+ FX_BOOL bFirst);

FX_BOOL LoadCrossRefV5(FX_FILESIZE pos, FX_FILESIZE& prev, FX_BOOL bMainXRef);